From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Ostrovsky Subject: Re: [PATCH v3] x86: correct socket_cpumask allocation Date: Thu, 09 Jul 2015 11:36:35 -0400 Message-ID: <559E9503.9010405@oracle.com> References: <1436451837-26171-1-git-send-email-chao.p.peng@linux.intel.com> <559E905B.1070503@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <559E905B.1070503@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper , Chao Peng , xen-devel@lists.xen.org Cc: dario.faggioli@citrix.com, keir@xen.org, JBeulich@suse.com List-Id: xen-devel@lists.xenproject.org On 07/09/2015 11:16 AM, Andrew Cooper wrote: > On 09/07/15 15:23, Chao Peng wrote: >> For booting cpu, the socket number is not needed to be 0 so >> it needs to be computed by cpu number. >> >> For secondary cpu, phys_proc_id is not valid in CPU_PREPARE >> notifier(cpu_smpboot_alloc), so cpu_to_socket(cpu) can't be used. >> Instead, pre-allocate secondary_cpu_mask in cpu_smpboot_alloc() >> and later consume it in smp_store_cpu_info(). >> >> This patch also change socket_cpumask type from 'cpumask_var_t *' >> to 'cpumask_t **' so that smaller NR_CPUS works. >> >> Reported-by: Boris Ostrovsky >> Tested-by: Dario Faggioli >> Signed-off-by: Chao Peng > The v2 of this path seems to be holding up fine against the XenServer > test pool. No failures to boot encountered so far. > > Tested-by: Andrew Cooper > > As the differences between v2 and v3 appear largely mechanical and not > functional in nature, this Tested-by can probably still stand. Works for me as well. (You can add 'Tested-by: Boris Ostrovsky ' although I think by now there are enough of those) -boris