From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Dario Faggioli <dario.faggioli@citrix.com>,
Chao Peng <chao.p.peng@linux.intel.com>
Cc: boris.ostrovsky@oracle.com, keir@xen.org, JBeulich@suse.com,
xen-devel@lists.xen.org
Subject: Re: [PATCH v3] x86: correct socket_cpumask allocation
Date: Fri, 10 Jul 2015 15:47:54 +0100 [thread overview]
Message-ID: <559FDB1A.8030402@citrix.com> (raw)
In-Reply-To: <1436538580.22672.420.camel@citrix.com>
On 10/07/15 15:29, Dario Faggioli wrote:
> On Thu, 2015-07-09 at 22:23 +0800, Chao Peng wrote:
>> For booting cpu, the socket number is not needed to be 0 so
>> it needs to be computed by cpu number.
>>
> This made my system boot, yes... but now it does not shutdown! :-/
>
> I'm attaching the splat I see, reliably, on my testbox.
>
> I'll try have a look at this, but feel free (especially Chao) to preempt
> me, if you get to the solution quicker.
>
> Dario
>
> (XEN) ----[ Xen-4.6-unstable x86_64 debug=y Tainted: C ]----
> (XEN) CPU: 0
> (XEN) RIP: e008:[<ffff82d0801886aa>] cpu_smpboot_free+0x2b/0x255
> (XEN) RFLAGS: 0000000000010206 CONTEXT: hypervisor
> (XEN) rax: ffff83032072a5c0 rbx: 00000000ffffffff rcx: 0000000000000000
> (XEN) rdx: ffff82d08031ff00 rsi: 0000000000008008 rdi: 0000000000000001
> (XEN) rbp: ffff8300dbaefd40 rsp: ffff8300dbaefd20 r8: ffff830320729df0
> (XEN) r9: 00000000003206fd r10: 0000000000000001 r11: 0080000000000000
> (XEN) r12: 0000000000000001 r13: ffff82d08029e348 r14: 0000000000008008
> (XEN) r15: 0000000000008000 cr0: 000000008005003b cr4: 00000000000026e0
> (XEN) cr3: 00000000dba9c000 cr2: ffff830b2072a5b8
> (XEN) ds: 002b es: 002b fs: 0000 gs: 0000 ss: e010 cs: e008
> (XEN) Xen stack trace from rsp=ffff8300dbaefd20:
> (XEN) 0000000000008008 0000000000000001 ffff82d08029f140 ffff82d08029e348
> (XEN) ffff8300dbaefd70 ffff82d080189225 ffff82d08029f148 ffff82d08029f140
> (XEN) ffff82d08029e348 0000000000008008 ffff8300dbaefdc0 ffff82d08011c019
> (XEN) 0000000000000000 0000000000000001 ffff8300dbaefdb0 0000000000000000
> (XEN) 0000000000000000 0000000000000001 ffff82d080334a88 ffffffffffffffff
> (XEN) ffff8300dbaefe00 ffff82d08010153e ffff8300dbaefdf0 ffff82d08029e340
> (XEN) 0000000052414d44 0000000000000001 0000000000000001 ffff82d08028aca0
> (XEN) ffff8300dbaefe30 ffff82d080101744 0000000000000000 0000000000000005
> (XEN) ffff82d080334b60 ffff82d080334a88 ffff8300dbaefe80 ffff82d0801a8967
> (XEN) ffff8300dbaefe60 ffff82d080165bee ffff82d080334a88 ffff830322da1400
> (XEN) ffff8300dbb3b000 ffff82d080334b60 ffff82d080334a88 ffffffffffffffff
> (XEN) ffff8300dbaefea0 ffff82d080106212 ffff8300dbb3b1d0 0000000000000000
> (XEN) ffff8300dbaefec0 ffff82d08012f8ae ffff8300dbaefec0 ffff82d080334b70
> (XEN) ffff8300dbaefef0 ffff82d08012fbe4 0000000cdb9d803e ffff8300dbae8000
> (XEN) 0000000cdb9d803e ffff8300dbdf4000 ffff8300dbaeff10 ffff82d0801617e0
> (XEN) ffff82d08012cb4c ffff8300dbdf4000 ffff8300dbaefe10 00000000001d6000
> (XEN) 00000000ffffffed 00000000001d6000 0000000000000000 ffff880012ae3eb0
> (XEN) 0000000000000000 0000000000000246 0000000000000040 0000000000000000
> (XEN) 00000000000000d2 0000000000000000 ffffffff810013aa 0100000000000000
> (XEN) 00000000deadbeef 00000000deadbeef 0000010000000000 ffffffff810013aa
> (XEN) Xen call trace:
> (XEN) [<ffff82d0801886aa>] cpu_smpboot_free+0x2b/0x255
> (XEN) [<ffff82d080189225>] cpu_smpboot_callback+0x317/0x327
> (XEN) [<ffff82d08011c019>] notifier_call_chain+0x67/0x87
> (XEN) [<ffff82d08010153e>] cpu_down+0xd9/0x12c
> (XEN) [<ffff82d080101744>] disable_nonboot_cpus+0x93/0x138
> (XEN) [<ffff82d0801a8967>] enter_state_helper+0xbd/0x365
> (XEN) [<ffff82d080106212>] continue_hypercall_tasklet_handler+0x4a/0xb1
> (XEN) [<ffff82d08012f8ae>] do_tasklet_work+0x78/0xab
> (XEN) [<ffff82d08012fbe4>] do_tasklet+0x5e/0x8a
> (XEN) [<ffff82d0801617e0>] idle_loop+0x56/0x6b
> (XEN)
> (XEN) Pagetable walk from ffff830b2072a5b8:
> (XEN) L4[0x106] = 00000000dba9a063 ffffffffffffffff
> (XEN) L3[0x02c] = 0000000000000000 ffffffffffffffff
> (XEN)
> (XEN) ****************************************
> (XEN) Panic on CPU 0:
> (XEN) FATAL PAGE FAULT
> (XEN) [error_code=0000]
> (XEN) Faulting linear address: ffff830b2072a5b8
> (XEN) ****************************************
Confirmed - this is also an issue for me. It is only shutdown; reboot
appears to be fine.
The splat, in case it highlights any further information:
Storage is finalized.
[ 102.874913] Power down.
(XEN) [ 106.477710] Preparing system for ACPI S5 state.
(XEN) [ 106.477725] Disabling non-boot CPUs ...
(XEN) [ 106.478770] Broke affinity for irq 16
(XEN) [ 106.478780] Broke affinity for irq 17
(XEN) [ 106.478789] Broke affinity for irq 20
(XEN) [ 106.479883] ----[ Xen-4.6.0-xs103036-d x86_64 debug=y Not
tainted ]----
(XEN) [ 106.479888] CPU: 0
(XEN) [ 106.479892] RIP: e008:[<ffff82d08018b7b9>]
cpu_smpboot_free+0x28/0x24c
(XEN) [ 106.479904] RFLAGS: 0000000000010206 CONTEXT: hypervisor
(XEN) [ 106.479911] rax: ffff83007fdb9e60 rbx: 00000000ffffffff
rcx: 0000000000010001
(XEN) [ 106.479917] rdx: ffff82d080365480 rsi: 0000000000008008
rdi: 0000000000000001
(XEN) [ 106.479922] rbp: ffff83007fd07d60 rsp: ffff83007fd07d40
r8: 0000000000000000
(XEN) [ 106.479927] r9: 0000000000000001 r10: ffff82e000ff5cc0
r11: 0000000000000001
(XEN) [ 106.479932] r12: 0000000000000001 r13: 0000000000008008
r14: ffff82d0802a3ca8
(XEN) [ 106.479937] r15: 0000000000008000 cr0: 000000008005003b
cr4: 00000000000026e0
(XEN) [ 106.479942] cr3: 000000007fca1000 cr2: ffff83087fdb9e58
(XEN) [ 106.479947] ds: 0000 es: 0000 fs: 0000 gs: 0000 ss:
e010 cs: e008
(XEN) [ 106.479952] Xen stack trace from rsp=ffff83007fd07d40:
(XEN) [ 106.479956] ffff82d0802a3ca8 0000000000000001
ffff82d0802a4820 0000000000008008
(XEN) [ 106.479965] ffff83007fd07d90 ffff82d08018c479
ffff82d0802a4828 ffff82d0802a4820
(XEN) [ 106.479974] 0000000000008008 ffff82d0802a3ca8
ffff83007fd07de0 ffff82d08011ed7a
(XEN) [ 106.479983] 0000000000000000 0000000000000001
ffff83007fd07dd0 0000000000000000
(XEN) [ 106.479990] 0000000000000001 0000000000000000
ffff83007fdbb000 ffff83007fae4000
(XEN) [ 106.479999] ffff83007fd07e20 ffff82d08010327e
ffff83007fd07e10 ffff82d0802a3ca0
(XEN) [ 106.480007] 0000000000000008 0000000000000001
0000000000000001 ffff82d08028f920
(XEN) [ 106.480015] ffff83007fd07e50 ffff82d080103485
0000000000000000 0000000000000005
(XEN) [ 106.480023] ffff82d08038bfe0 ffff83007fdbb000
ffff83007fd07e80 ffff82d0801abbb9
(XEN) [ 106.480032] ffff8300700b9680 ffff83007fdfc000
ffff82d08038bfe0 ffff83007fdbb000
(XEN) [ 106.480041] ffff83007fd07ea0 ffff82d0801082cf
ffff83007fdfc1d0 0000000000000000
(XEN) [ 106.480050] ffff83007fd07ec0 ffff82d08013278d
ffff83007fd07ec0 ffff82d08038bff0
(XEN) [ 106.480059] ffff83007fd07ef0 ffff82d080132abc
ffff82d08012f992 ffff83007fd00000
(XEN) [ 106.480068] ffff83007fdfc000 00000000ffffffff
ffff83007fd07f10 ffff82d08016486b
(XEN) [ 106.480077] ffff82d08012f9ea ffff83007fdba000
ffff83007fd07da8 00000000fee1dead
(XEN) [ 106.480085] 0000000000000801 0000000000000005
0000000000002801 ffff88002543dd78
(XEN) [ 106.480093] ffffffff81a73208 0000000000000246
666f5f7265776f70 000000000000034b
(XEN) [ 106.480102] 0000000000000005 0000000000000000
ffffffff810010ea 0000000000002801
(XEN) [ 106.480110] 0000000000002801 00000000deadbeef
0000010000000000 ffffffff810010ea
(XEN) [ 106.480118] 000000000000e033 0000000000000246
ffff88002543dcd0 000000000000e02b
(XEN) [ 106.480127] Xen call trace:
(XEN) [ 106.480132] [<ffff82d08018b7b9>] cpu_smpboot_free+0x28/0x24c
(XEN) [ 106.480139] [<ffff82d08018c479>]
cpu_smpboot_callback+0x424/0x444
(XEN) [ 106.480146] [<ffff82d08011ed7a>] notifier_call_chain+0x6a/0x90
(XEN) [ 106.480151] [<ffff82d08010327e>] cpu_down+0xc9/0x11d
(XEN) [ 106.480157] [<ffff82d080103485>] disable_nonboot_cpus+0x91/0x13e
(XEN) [ 106.480163] [<ffff82d0801abbb9>] enter_state_helper+0xb7/0x376
(XEN) [ 106.480170] [<ffff82d0801082cf>]
continue_hypercall_tasklet_handler+0x4a/0xb1
(XEN) [ 106.480176] [<ffff82d08013278d>] do_tasklet_work+0x78/0xab
(XEN) [ 106.480181] [<ffff82d080132abc>] do_tasklet+0x5e/0x8a
(XEN) [ 106.480187] [<ffff82d08016486b>] idle_loop+0x56/0x70
(XEN) [ 106.480191]
(XEN) [ 106.480195] Pagetable walk from ffff83087fdb9e58:
(XEN) [ 106.480200] L4[0x106] = 000000007fc9f063 ffffffffffffffff
(XEN) [ 106.480205] L3[0x021] = 0000000000000000 ffffffffffffffff
(XEN) [ 106.840985]
(XEN) [ 106.842975] ****************************************
(XEN) [ 106.848426] Panic on CPU 0:
(XEN) [ 106.851716] FATAL PAGE FAULT
(XEN) [ 106.855090] [error_code=0000]
(XEN) [ 106.858554] Faulting linear address: ffff83087fdb9e58
(XEN) [ 106.864090] ****************************************
(XEN) [ 106.869544]
(XEN) [ 106.871534] Reboot in five seconds...
next prev parent reply other threads:[~2015-07-10 14:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 14:23 [PATCH v3] x86: correct socket_cpumask allocation Chao Peng
2015-07-09 15:16 ` Andrew Cooper
2015-07-09 15:36 ` Boris Ostrovsky
2015-07-10 14:29 ` Dario Faggioli
2015-07-10 14:47 ` Andrew Cooper [this message]
2015-07-10 14:57 ` Dario Faggioli
2015-07-10 15:13 ` Jan Beulich
2015-07-10 15:25 ` Jan Beulich
2015-07-10 16:03 ` Dario Faggioli
2015-07-13 3:19 ` Chao Peng
2015-07-10 15:33 ` Dario Faggioli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559FDB1A.8030402@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=chao.p.peng@linux.intel.com \
--cc=dario.faggioli@citrix.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).