From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Dunlap <george.dunlap@eu.citrix.com>
Subject: Re: [PATCH v3 05/13] x86/altp2m: basic data structures
 and support routines.
Date: Tue, 14 Jul 2015 12:34:41 +0100
Message-ID: <55A4F3D1.8050704@eu.citrix.com>
References: <1435774177-6345-1-git-send-email-edmund.h.white@intel.com>
	<1435774177-6345-6-git-send-email-edmund.h.white@intel.com>
	<559E936E020000780008ED56@mail.emea.novell.com>
	<DBC12B0F5509554280826E40BCDEE8BE54FD26E0@ORSMSX104.amr.corp.intel.com>
	<55A38C75020000780008FF5C@mail.emea.novell.com>
	<DBC12B0F5509554280826E40BCDEE8BE54FD4016@ORSMSX104.amr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <DBC12B0F5509554280826E40BCDEE8BE54FD4016@ORSMSX104.amr.corp.intel.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: "Sahita, Ravi" <ravi.sahita@intel.com>, Jan Beulich <JBeulich@suse.com>
Cc: Tim Deegan <tim@xen.org>, Wei Liu <wei.liu2@citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, "White,
	Edmund H" <edmund.h.white@intel.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, "tlengyel@novetta.com" <tlengyel@novetta.com>, Daniel De Graaf <dgdegra@tycho.nsa.gov>
List-Id: xen-devel@lists.xenproject.org

On 07/14/2015 01:01 AM, Sahita, Ravi wrote:
> 
> 
>> -----Original Message-----
>> From: Jan Beulich [mailto:JBeulich@suse.com]
>> Sent: Monday, July 13, 2015 1:01 AM
>>
>>>>> On 10.07.15 at 23:48, <ravi.sahita@intel.com> wrote:
>>>> From: Jan Beulich [mailto:JBeulich@suse.com]
>>>> Sent: Thursday, July 09, 2015 6:30 AM
>>>>
>>>>>>> On 01.07.15 at 20:09, <edmund.h.white@intel.com> wrote:
>>>>> ---
>>>>>  xen/arch/x86/hvm/Makefile        |  1 +
>>>>>  xen/arch/x86/hvm/altp2m.c        | 92
>>>> +++++++++++++++++++++++++++++++++++++
>>>>
>>>> Wouldn't this better go into xen/arch/x86/mm/?
>>>
>>> In this case we followed the pattern of nestedhvm - hope that's ok.
>>
>> Not really imo: Nested HVM obviously belongs in hvm/; alt-P2m is more of a
>> mm extension than a HVM one afaict, and hence would rather belong in mm/.
>>
> 
> Would like George's opinion also on this before we make this change (again want to avoid thrashing on things like this).

This is a bit of a murky one, since the whole reason you're doing this
is that you actually do use hardware to do the VMFUNC and p2m switching.

Let me take a look at v5 and see what I think (as it sounds like some of
the hvm_function hooks have disappeared).

 -George