From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= Subject: Re: [PATCH v2 0/3] arm64: Add multiboot support (via fdt) for Xen boot Date: Wed, 15 Jul 2015 17:56:18 +0200 Message-ID: <55A682A2.8000500@gmail.com> References: <=fu.wei@linaro.org> <1436777640-31871-1-git-send-email-fu.wei@linaro.org> Reply-To: The development of GNU GRUB Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6847154763238668992==" Return-path: In-Reply-To: <1436777640-31871-1-git-send-email-fu.wei@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: grub-devel-bounces+gcbgd-grub-devel=m.gmane.org@gnu.org Sender: grub-devel-bounces+gcbgd-grub-devel=m.gmane.org@gnu.org To: fu.wei@linaro.org, grub-devel@gnu.org, arvidjaar@gmail.com Cc: xen-devel@lists.xensource.com, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com, jcm@redhat.com, leif.lindholm@linaro.org, ryan.harkin@linaro.org, linaro-uefi@lists.linaro.org List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============6847154763238668992== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="S5LBfWDMpTbP42GgwQuWDE6VqlqU45VFD" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --S5LBfWDMpTbP42GgwQuWDE6VqlqU45VFD Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 13.07.2015 10:53, fu.wei@linaro.org wrote: > From: Fu Wei >=20 > - This adds support for the Xen boot on ARM specification for arm64. >=20 > - The implementation for Xen is following : > http://wiki.xen.org/wiki/Xen_ARM_with_Virtualization_Extensions/Mul= tiboot > and xen/docs/misc/arm/device-tree/booting.txt in Xen source code. >=20 > - The multiboot/module commands have existed, so we use=20 > xen_hypervisor/xen_module instead. >=20 > - This Xen boot support is built into linux module for aarch64, > and can not be used alone. >=20 > - Adding this functionality to the existing "linux" module is for > reusing the existing code of devicetree. >=20 This is a misguided decision. Modules can depend on other modules. Ideally shared functionality should be in a separate module but having xen depend on linux is an OK stopgap solution. Putting everything in one module is bad. > - Add the support of xen_hypervisor/xen_module commands in util/grub.= d/20_linux_xen.in >=20 > - Add the introduction of xen_hypervisor/xen_module commands in docs/= grub.texi >=20 > - The example of this support is > https://wiki.linaro.org/LEG/Engineering/Grub2/Xen_booting_on_Founda= tion_FVP_model_by_GRUB >=20 > Changelog: > v2: remove the patches which have been accepted. > according to Vladimir's suggestion, change the command manes > and relevant code: > multiboot-->xen_hypervisor > module-->xen_module > improve the option parsing support for xen_hypervisor/xen_module co= mmands. > add a patch for adding xen_hypervisor/xen_module support > in util/grub.d/20_linux_xen.in. > update docs/grub.texi patch for the new command names. >=20 > v1: The first version upstream patchset to grub-devel mailing list >=20 >=20 > Fu Wei (3): > arm64: Add Xen boot support file > * util/grub.d/20_linux_xen.in: Add support of the XEN boot on aarch64= > arm64: Add the introduction of xen_hypervisor/xen_module command in > docs/grub.texi >=20 > docs/grub.texi | 27 ++ > grub-core/Makefile.core.def | 1 + > grub-core/loader/arm64/linux.c | 6 + > grub-core/loader/arm64/xen_boot.c | 615 ++++++++++++++++++++++++++++++= ++++++++ > include/grub/arm64/xen_boot.h | 115 +++++++ > util/grub.d/20_linux_xen.in | 14 +- > 6 files changed, 775 insertions(+), 3 deletions(-) > create mode 100644 grub-core/loader/arm64/xen_boot.c > create mode 100644 include/grub/arm64/xen_boot.h >=20 --S5LBfWDMpTbP42GgwQuWDE6VqlqU45VFD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iF4EAREKAAYFAlWmgqIACgkQmBXlbbo5nOufEwD7BBfs05LWxgwIQw/LiCM6Dl6w MVkNZek5qm9GLYQHJyIA/00v4218Iv3pBV4RwWQFx+u+7fvPkLvub/ha8N8dbvrS =w+gk -----END PGP SIGNATURE----- --S5LBfWDMpTbP42GgwQuWDE6VqlqU45VFD-- --===============6847154763238668992== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel --===============6847154763238668992==--