From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yang Hongyang <yanghy@cn.fujitsu.com>
Subject: Re: [PATCH v4 --for 4.6 COLOPre 13/25] migration/save:
 pass checkpointed_stream from libxl to libxc
Date: Fri, 17 Jul 2015 00:24:11 +0800
Message-ID: <55A7DAAB.2000400@cn.fujitsu.com>
References: <1436946351-21118-1-git-send-email-yanghy@cn.fujitsu.com>
	<1436946351-21118-14-git-send-email-yanghy@cn.fujitsu.com>
	<20150716161040.GZ12455@zion.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20150716161040.GZ12455@zion.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: Ian Campbell <Ian.Campbell@citrix.com>, wency@cn.fujitsu.com, andrew.cooper3@citrix.com, yunhong.jiang@intel.com, eddie.dong@intel.com, xen-devel@lists.xen.org, guijianfeng@cn.fujitsu.com, rshriram@cs.ubc.ca, Ian Jackson <Ian.Jackson@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org



On 07/17/2015 12:10 AM, Wei Liu wrote:
> On Wed, Jul 15, 2015 at 03:45:39PM +0800, Yang Hongyang wrote:
>> Pass checkpointed_stream from libxl to libxc.
>> It won't affact legacy migration because legacy migration
>> won't use this param.
>>
>> Signed-off-by: Yang Hongyang <yanghy@cn.fujitsu.com>
>> CC: Ian Campbell <Ian.Campbell@citrix.com>
>> CC: Ian Jackson <Ian.Jackson@eu.citrix.com>
>> CC: Wei Liu <wei.liu2@citrix.com>
>> CC: Andrew Cooper <andrew.cooper3@citrix.com>
>> ---
> [...]
>>
>> +    if (dss->checkpointed_stream && !r_info) {
>
> Please explicitly check for _NONE type instead of relying it of being 0.
> Arguably the actual value is not going to change in the future but it's
> better to be explicit.

I think you mean check xxx != _NONE here, right? will fix.

>
> Wei.
>
>> +        LOG(ERROR, "Migration stream is checkpointed, but there's no "
>> +                   "checkpoint info!");
>> +        goto out;
>> +    }
>> +
>>       dss->rc = 0;
>>       logdirty_init(&dss->logdirty);
>>       dsps->ao = ao;
> .
>

-- 
Thanks,
Yang.