[PATCH] xen: arm: gic-v3: avoid \n in the middle of log messages

[PATCH] xen: arm: gic-v3: avoid \n in the middle of log messages

[Ian Campbell]

These result in log messages such as:

(XEN) d0v0: vGICD: RAZ on reserved register offset 0x00000c
(XEN) d0v0: vGICR: write r2 offset 0x000180
(XEN)  not found<G><3>traps.c:2417:d0v0 HSR=0x93820046 pc=0xffffffc000322bfc gva=0xffffff8000090180 gpa=0x0000008d110180

Fix this by rewording without a \n in the middle. Also add one at the end.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
 xen/arch/arm/vgic-v3.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
index 683e3cc..f1c482d 100644
--- a/xen/arch/arm/vgic-v3.c
+++ b/xen/arch/arm/vgic-v3.c
@@ -193,7 +193,7 @@ static int __vgic_v3_rdistr_rd_mmio_read(struct vcpu *v, mmio_info_t *info,
         goto read_as_zero_32;
     default:
         printk(XENLOG_G_ERR
-               "%pv: vGICR: read r%d offset %#08x\n not found",
+               "%pv: vGICR: unhandled read r%d offset %#08x\n",
                v, dabt.reg, gicr_reg);
         return 0;
     }
@@ -269,7 +269,7 @@ static int __vgic_v3_rdistr_rd_mmio_write(struct vcpu *v, mmio_info_t *info,
         /* RO */
         goto write_ignore_32;
     default:
-        printk(XENLOG_G_ERR "%pv: vGICR: write r%d offset %#08x\n not found",
+        printk(XENLOG_G_ERR "%pv: vGICR: unhandled write r%d offset %#08x\n",
                v, dabt.reg, gicr_reg);
         return 0;
     }
@@ -515,7 +515,7 @@ static int vgic_v3_rdistr_sgi_mmio_read(struct vcpu *v, mmio_info_t *info,
 
     default:
         printk(XENLOG_G_ERR
-               "%pv: vGICR: SGI: read r%d offset %#08x\n not found",
+               "%pv: vGICR: SGI: unhandled read r%d offset %#08x\n",
                v, dabt.reg, gicr_reg);
         return 0;
     }
@@ -576,7 +576,7 @@ static int vgic_v3_rdistr_sgi_mmio_write(struct vcpu *v, mmio_info_t *info,
         goto write_ignore_32;
     default:
         printk(XENLOG_G_ERR
-               "%pv: vGICR: SGI: write r%d offset %#08x\n not found",
+               "%pv: vGICR: SGI: unhandled write r%d offset %#08x\n",
                v, dabt.reg, gicr_reg);
         return 0;
     }
-- 
2.1.4

Re: [PATCH] xen: arm: gic-v3: avoid \n in the middle of log messages

[Julien Grall]

Hi Ian,

On 17/07/15 14:21, Ian Campbell wrote:
> These result in log messages such as:
> 
> (XEN) d0v0: vGICD: RAZ on reserved register offset 0x00000c
> (XEN) d0v0: vGICR: write r2 offset 0x000180
> (XEN)  not found<G><3>traps.c:2417:d0v0 HSR=0x93820046 pc=0xffffffc000322bfc gva=0xffffff8000090180 gpa=0x0000008d110180
> 
> Fix this by rewording without a \n in the middle. Also add one at the end.
> 
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>

Reviewed-by: Julien Grall <julien.grall@citrix.com>

Regards,

-- 
Julien Grall

Re: [PATCH] xen: arm: gic-v3: avoid \n in the middle of log messages

[Ian Campbell]

On Fri, 2015-07-17 at 15:10 +0100, Julien Grall wrote:
> Hi Ian,
> 
> On 17/07/15 14:21, Ian Campbell wrote:
> > These result in log messages such as:
> > 
> > (XEN) d0v0: vGICD: RAZ on reserved register offset 0x00000c
> > (XEN) d0v0: vGICR: write r2 offset 0x000180
> > (XEN)  not found<G><3>traps.c:2417:d0v0 HSR=0x93820046 
> > pc=0xffffffc000322bfc gva=0xffffff8000090180 gpa=0x0000008d110180
> > 
> > Fix this by rewording without a \n in the middle. Also add one at 
> > the end.
> > 
> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> 
> Reviewed-by: Julien Grall <julien.grall@citrix.com>

Applied thanks.