From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Chen, Tiejun" <tiejun.chen@intel.com>
Subject: Re: [v9][PATCH 07/16] hvmloader/e820: construct guest
 e820 table
Date: Mon, 20 Jul 2015 14:19:29 +0800
Message-ID: <55AC92F1.2010703@intel.com>
References: <1437093920-11472-1-git-send-email-tiejun.chen@intel.com>
	<1437093920-11472-8-git-send-email-tiejun.chen@intel.com>
	<55A8CD740200007800092545@mail.emea.novell.com>
	<55A8C65C.1020804@intel.com>
	<55A8FA26020000780009269C@mail.emea.novell.com>
	<55A91DAD.7030900@intel.com>
	<55A93BF702000078000928B0@mail.emea.novell.com>
	<55A9254B.2070900@intel.com>
	<55A94418020000780009293E@mail.emea.novell.com>
	<CAFLBxZYw9UvvFagnESF+nC-u7VjEu7JyMSdx8D7BXrYofei=MQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CAFLBxZYw9UvvFagnESF+nC-u7VjEu7JyMSdx8D7BXrYofei=MQ@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: George Dunlap <George.Dunlap@eu.citrix.com>, Jan Beulich <JBeulich@suse.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, Keir Fraser <keir@xen.org>
List-Id: xen-devel@lists.xenproject.org

>>>> Before you add memory_map.nr_map, you should be able to iterate
>>>> from 0 to (not inclusive) nr. At least as far as I recall the original
>>>> patch.
>>>>
>>>
>>> Sorry, I really don't understand what you want.
>>>
>>> Before we add memory_map.nr_map, e820[0, nr) don't include low/high
>>> memory, right?
>>
>> Why? memory_map is representing the reserved areas only, isn't it?
>> If that's not the case, then of course everything is fine.
>
> I'm pretty sure the memory map we get here is an extension of the
> original PV-only get_e820 hypercall, which *does* include both the
> lowmem and highmem regions.
>
> In any case, it's pretty clear from the patched code that Tiejun is
> removing the old code which created the lowmem and highmem regions and
> is not replacing it.  Where do you think the highmem region he's
> looking for was coming from?
>

On second thoughts, I prefer to check/sync memory_map.map[] before copy 
them into e820 since ultimately this can make sure hvm_info, 
memory_map.map[] and e820 are on the same page.

Anyway, I would send out v10 to address others so please further post 
your comments over there.

Thanks
Tiejun