From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Chen, Tiejun" <tiejun.chen@intel.com>
Subject: Re: [PATCH 11/16] tools/libxl: detect and avoid
	conflicts with RDM
Date: Thu, 23 Jul 2015 08:52:24 +0800
Message-ID: <55B03AC8.2080503@intel.com>
References: <1437579859-24485-1-git-send-email-ian.jackson@eu.citrix.com>
	<1437579859-24485-12-git-send-email-ian.jackson@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1437579859-24485-12-git-send-email-ian.jackson@eu.citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xensource.com
Cc: George Dunlap <George.Dunlap@eu.citrix.com>, Wei Liu <wei.liu2@citrix.com>, Ian Campbell <ian.campbell@citrix.com>, Jan Beulich <JBeulich@suse.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

Ian,

Thanks for your effort.

A tiny change may be needed but I don't block this.

> +libxl__xc_device_get_rdm(libxl__gc *gc,
> +                         uint32_t flag,

Since now we are sitting on xc_reserved_device_memory_map(, flags, xxx), 
s/flag/flags may be better.

> +                         uint16_t seg,
> +                         uint8_t bus,
> +                         uint8_t devfn,
> +                         unsigned int *nr_entries,
> +                         struct xen_reserved_device_memory **xrdm)
> +{

[snip]

> +    r = xc_reserved_device_memory_map(CTX->xch, flag, seg, bus, devfn,

Ditto.

> +                                      NULL, nr_entries);
> +    assert(r <= 0);
> +    /* "0" means we have no any rdm entry. */
> +    if (!r) goto out;
> +
> +    if (errno != ENOBUFS) {
> +        rc = ERROR_FAIL;
> +        goto out;
> +    }
> +
> +    GCNEW_ARRAY(*xrdm, *nr_entries);
> +    r = xc_reserved_device_memory_map(CTX->xch, flag, seg, bus, devfn,

Ditto.

Thanks
Tiejun