From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Chen, Tiejun" <tiejun.chen@intel.com>
Subject: Re: [PATCH 03/16] xen/passthrough: extend hypercall to
 support rdm reservation policy
Date: Thu, 23 Jul 2015 20:15:44 +0800
Message-ID: <55B0DAF0.4010706@intel.com>
References: <1437579859-24485-1-git-send-email-ian.jackson@eu.citrix.com>
	<1437579859-24485-4-git-send-email-ian.jackson@eu.citrix.com>
	<21936.54212.592097.157376@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <21936.54212.592097.157376@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>, xen-devel@lists.xensource.com, Wei Liu <wei.liu2@citrix.com>, Jan Beulich <JBeulich@suse.com>, Ian Campbell <ian.campbell@citrix.com>, George Dunlap <George.Dunlap@eu.citrix.com>, Tim Deegan <tim@xen.org>, Keir Fraser <keir@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>, Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>, Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>, Stefano Stabellini <stefano.stabellini@citrix.com>, Yang Zhang <yang.z.zhang@intel.com>, Kevin Tian <kevin.tian@intel.com>
List-Id: xen-devel@lists.xenproject.org

> Tiejun, please can you send a patch to fix this up.  Please send just
> a revised version of this patch.  I think the rest of the series will
> rebase just fine on top of it.  (If I'm wrong then we will need to do
> something more complex.)

Sorry to this.


     On ARM side the flag field doesn't take any affect.

     Signed-off-by: Tiejun Chen <tiejun.chen@intel.com>

diff --git a/xen/drivers/passthrough/arm/smmu.c 
b/xen/drivers/passthrough/arm/smmu.c
index 9a667e9..b62c8cf 100644
--- a/xen/drivers/passthrough/arm/smmu.c
+++ b/xen/drivers/passthrough/arm/smmu.c
@@ -2709,7 +2709,8 @@ static int arm_smmu_reassign_dev(struct domain *s, 
struct domain *t,
                 return ret;

         if (t) {
-               ret = arm_smmu_assign_dev(t, devfn, dev);
+               /* The flag field doesn't matter to DT device. */
+               ret = arm_smmu_assign_dev(t, devfn, dev, 0);
                 if (ret)
                         return ret;
         }


Thanks
Tiejun