From mboxrd@z Thu Jan  1 00:00:00 1970
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: PV-vNUMA issue: topology is misinterpreted by the
 guest
Date: Fri, 24 Jul 2015 12:03:01 -0400
Message-ID: <55B261B5.4010806@oracle.com>
References: <1437042762.28251.18.camel@citrix.com>
	<55A7A7F40200007800091D60@mail.emea.novell.com>
	<55A78DF2.1060709@citrix.com>
	<20150716152513.GU12455@zion.uk.xensource.com>
	<55A7D17C.5060602@citrix.com> <55A7D2CC.1050708@oracle.com>
	<55A7F7F40200007800092152@mail.emea.novell.com>
	<55A7DE45.4040804@citrix.com> <55A7E2D8.3040203@oracle.com>
	<55A8B83802000078000924AE@mail.emea.novell.com>
	<1437118075.23656.25.camel@citrix.com>
	<55A946C6.8000002@oracle.com> <1437401354.5036.19.camel@citrix.com>
	<55AD08F7.7020105@oracle.com> <55AEA4DD.7080406@oracle.com>
	<1437572160.5036.39.camel@citrix.com>
	<55AF9F8F.7030200@suse.com> <55AFA16B.3070103@oracle.com>
	<55AFA41E.1080101@suse.com> <1437576645.5036.56.camel@citrix.com>
	<55AFB773.7010906@oracle.com> <1437580199.5036.64.camel@citrix.com>
	<55AFDC7B.60909@oracle.com>
	<55B0B2FB02000078000945C4@prv-mh.provo.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <boris.ostrovsky@oracle.com>) id 1ZIfS9-0005Ow-35
	for xen-devel@lists.xenproject.org; Fri, 24 Jul 2015 16:04:05 +0000
In-Reply-To: <55B0B2FB02000078000945C4@prv-mh.provo.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Elena Ufimtseva <elena.ufimtseva@oracle.com>, Juergen Gross <JGross@suse.com>, Wei Liu <wei.liu2@citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Dario Faggioli <dario.faggioli@citrix.com>, David Vrabel <david.vrabel@citrix.com>, "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
List-Id: xen-devel@lists.xenproject.org

On 07/23/2015 03:25 AM, Jan Beulich wrote:
>>>> On 22.07.15 at 20:10, <boris.ostrovsky@oracle.com> wrote:
>> I don't think this is currently doable with what we have for CPUID
>> support in xl syntax. I am pretty sure we need to at least be able to
>> specify all leaf 4's indexes. And we can't.
>>
>> BTW, irrespective of this particular problem, adding support for indexed
>> CPUID leaves would be a good idea.
> So what is it that makes you think this doesn't work already?
> xc_cpuid_policy() intentionally has "input" as a pointer,
> allowing not just EAX to be specified. And libxl_cpuid.c also
> has
>
> static const char *input_names[2] = { "leaf", "subleaf" };
>

Right. I wasn't aware of this and until I looked at 
libxl_cpuid_parse_config_xend() I wouldn't have known what the syntax 
for specifying subleaves is because we don't describe it in xl man page 
(at least I can't find it).

In which case we may be able to adjust them and see what effect they have.


-boris