From mboxrd@z Thu Jan  1 00:00:00 1970
From: Don Slutz <don.slutz@gmail.com>
Subject: Re: [PATCH v12 3/8] tools: Add vmware_hwver support
Date: Mon, 27 Jul 2015 22:58:53 -0400
Message-ID: <55B6EFED.8010802@Gmail.com>
References: <1435447665-5433-1-git-send-email-Don.Slutz@Gmail.com>	
	<1435447665-5433-4-git-send-email-Don.Slutz@Gmail.com>	
	<20150701201408.GD27014@l.oracle.com>
	<1436284765.25646.262.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1436284765.25646.262.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Tim Deegan <tim@xen.org>, Kevin Tian <kevin.tian@intel.com>, Keir Fraser <keir@xen.org>, Jun Nakajima <jun.nakajima@intel.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, George Dunlap <George.Dunlap@eu.citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Eddie Dong <eddie.dong@intel.com>, Don Slutz <dslutz@verizon.com>, xen-devel@lists.xen.org, Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>, Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
List-Id: xen-devel@lists.xenproject.org

On 07/07/15 11:59, Ian Campbell wrote:
> On Wed, 2015-07-01 at 16:14 -0400, Konrad Rzeszutek Wilk wrote:
>> On Sat, Jun 27, 2015 at 07:27:40PM -0400, Don Slutz wrote:
>>> From: Don Slutz <dslutz@verizon.com>


>>> +In a .ovf it is part of the value of vssd:VirtualSystemType.
>>> +For vssd:VirtualSystemType == vmx-07, vmware_hwver = 7.
>>> +
>>> +=back
>>> +
>>
>> Perhaps add 'Recommended value is 7' ?
> 
> Assuming that is a good recommendation then that might be a good
> enhancement for a future patch. Or perhaps some sort of simple mapping
> from VMware product versions/names to a suitable value to use, unless
> that means having to think about trademarks etc.
> 

I would be happy to continue this as a new patch.

   -Don Slutz

> Ian.
>