From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v5 08/22] xen/arm: ITS: Add virtual ITS commands support Date: Fri, 31 Jul 2015 11:16:28 +0100 Message-ID: <55BB4AFC.4070707@citrix.com> References: <1437995524-19772-1-git-send-email-vijay.kilari@gmail.com> <1437995524-19772-9-git-send-email-vijay.kilari@gmail.com> <55B7C419.2040406@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Vijay Kilari Cc: Ian Campbell , Stefano Stabellini , Prasun Kapoor , manish.jaggi@caviumnetworks.com, Tim Deegan , "xen-devel@lists.xen.org" , Stefano Stabellini , Vijaya Kumar K List-Id: xen-devel@lists.xenproject.org On 31/07/15 07:57, Vijay Kilari wrote: >>> /* >>> * Local variables: >>> * mode: C >>> diff --git a/xen/include/asm-arm/gic-its.h b/xen/include/asm-arm/gic-its.h >>> index 66be53a..cdb786c 100644 >>> --- a/xen/include/asm-arm/gic-its.h >>> +++ b/xen/include/asm-arm/gic-its.h >>> @@ -21,6 +21,8 @@ >>> #include >>> #include >>> >>> +#define MASK_4K 0xfffffffff000UL >> >> If you name the macro MASK_4K this should go in xen/sizes.h and not in >> the gic-its.h. Although on v4 [1], Ian suggested to rename into >> GITS_CBASER_PA_MASK which IHMO would be better. > > > This is used by other generic code as well in later patches. > One option is to introduce separate macro for each usage or generic name like > GITS_PA_MASK IHMO a mask per register would be better. Regards, -- Julien Grall