From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shannon Zhao Subject: Re: [PATCH 1/2] ACPI/table: Always count matched and successfully parsed entries Date: Wed, 12 Aug 2015 16:58:50 +0800 Message-ID: <55CB0ACA.9080706@huawei.com> References: <1438661972-10140-1-git-send-email-zhaoshenglong@huawei.com> <1438661972-10140-2-git-send-email-zhaoshenglong@huawei.com> <55CB25380200007800099FD5@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <55CB25380200007800099FD5@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: shannon.zhao@linaro.org, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 2015/8/12 16:51, Jan Beulich wrote: >>>> On 04.08.15 at 06:19, wrote: >> From: Shannon Zhao > > This is not true. All you did is port a Linux change. > Will change this. >> acpi_parse_entries() allows to traverse all available table entries (aka >> subtables) by passing max_entries parameter equal to 0, but since its count >> variable is only incremented if max_entries is not 0, the function always >> returns 0 for max_entries equal to 0. It would be more useful if it returned >> the number of entries matched instead, so make it increment count in that >> case too. >> >> Signed-off-by: Tomasz Nowicki >> Signed-off-by: Shannon Zhao > > Please mention the respective Linux commit. Without that I would > complain that "more useful" is too fuzzy (as in not making clear to > whom and why). > Ok, will add it. Thanks. -- Shannon