From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [RFC 2/2] xen/public: grant-table: Specificy the size of the grant Date: Wed, 12 Aug 2015 11:00:42 +0100 Message-ID: <55CB194A.2060901@citrix.com> References: <1438774133-1564-1-git-send-email-julien.grall@citrix.com> <1438774133-1564-3-git-send-email-julien.grall@citrix.com> <55CB100E0200007800099F21@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZPSpz-00022T-Ao for xen-devel@lists.xenproject.org; Wed, 12 Aug 2015 10:00:47 +0000 In-Reply-To: <55CB100E0200007800099F21@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Wei.Liu2@citrix.com, ian.campbell@citrix.com, Tim Deegan , Ian Jackson , stefano.stabellini@citrix.com, xen-devel@lists.xenproject.org, Keir Fraser List-Id: xen-devel@lists.xenproject.org On 12/08/2015 08:21, Jan Beulich wrote: > This paragraph should get "on ARM" added somewhere. There is no > inherent requirement for such a restriction on another architecture > Xen might get ported to; the only restriction of the current interface > is that it can't support page sizes from 64k up. On an architecture > e.g. not supporting other than 8k pages things would still be fine, > yet the comment above would then be wrong. > > An alternative might be to say "... is always the smallest > architecturally supported page size (e.g. 4k on x86 and ARM) > irrespective of ...". While this is true today, I don't see anything that would prevent a new architecture to respect this. What about replacing 4KB by "Xen Page size" and define this size per architecture in arch-*.h? Regards, -- Julien Grall