From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH 2/2] xen/arm: support compressed kernels Date: Wed, 12 Aug 2015 16:27:26 +0100 Message-ID: <55CB65DE.7080904@citrix.com> References: <1439390875-21256-2-git-send-email-stefano.stabellini@eu.citrix.com> <1439391830.8356.49.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Stefano Stabellini , Ian Campbell Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 12/08/15 16:22, Stefano Stabellini wrote: >>> obj-$(perfc) += perfc.o >>> obj-$(crash_debug) += gdbstub.o >>> diff --git a/xen/include/asm-arm/byteorder.h b/xen/include/asm >>> -arm/byteorder.h >>> index 9c712c4..3b7feda 100644 >>> --- a/xen/include/asm-arm/byteorder.h >>> +++ b/xen/include/asm-arm/byteorder.h >>> @@ -5,6 +5,8 @@ >>> >>> #include >>> >>> +#define CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS >> >> While CONFIG_HAVE_UNALIGNED_ACCESS might be true on arm64 it may not be the >> case that it is efficient. Also I'm not sure about arm32 at all. > > It is true on arm archs >= v8, so we should be fine. See: I guess you meant v6? Although, unaligned access are not allowed in Xen on ARM32. See arm32/head.S:353 Given that the uncompress code is only used for decompressing DOM0 kernel, I don't think it's worth to enable unaligned access. Regards, -- Julien Grall