xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Wei Liu <wei.liu2@citrix.com>,
	Dario Faggioli <dario.faggioli@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>,
	Ian Campbell <ian.campbell@citrix.com>
Subject: Empty memory nodes in VNUMA
Date: Fri, 14 Aug 2015 11:19:53 -0400	[thread overview]
Message-ID: <55CE0719.9000608@oracle.com> (raw)
In-Reply-To: <1439480480-20939-1-git-send-email-wei.liu2@citrix.com>

What is the purpose of 'nr_vmemranges < nr_vnodes' test in 
xc_domain_setvnuma()? Can't we have nodes with no memory?

If that's the case, this check will still miss configurations when a 
node spans multiple memory ranges.

For example, this fails:

vcpus = 4
vnuma = [ [ "pnode=0","size=2048","vcpus=0-1" ],
           [ "pnode=1","size=1800" ],
           [ "pnode=2","size=0","vcpus=2-3" ],
           [ "pnode=3","size=100" ] ]

but this

vcpus = 4
vnuma = [ [ "pnode=0","size=2048","vcpus=0-1" ],
           [ "pnode=1","size=1801" ],
           [ "pnode=2","size=0","vcpus=2-3" ],
           [ "pnode=3","size=100" ] ]

does not: because of MMIO hole this will cause a second 1MB range to be 
created on node 1 (in libxl__vnuma_build_vmemrange_hvm()).

Can we drop this check?


-boris

  parent reply	other threads:[~2015-08-14 15:20 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-13 15:41 [PATCH for-4.6 v2 0/3] More vNUMA fixes Wei Liu
2015-08-13 15:41 ` [PATCH for-4.6 v2 1/3] xl: fix vNUMA vdistance parsing Wei Liu
2015-08-16  8:46   ` Ian Campbell
2015-08-13 15:41 ` [PATCH for-4.6 v2 2/3] xl: error out if vNUMA specifies more vcpus than pcpus Wei Liu
2015-08-13 23:25   ` Dario Faggioli
2015-08-13 23:38     ` Wei Liu
2015-08-14 10:19       ` Dario Faggioli
2015-08-16  8:51       ` Ian Campbell
2015-08-17 18:42         ` Wei Liu
2015-08-13 15:41 ` [PATCH for-4.6 v2 3/3] libxc: fix vNUMA memory allocation Wei Liu
2015-08-16  8:47   ` Ian Campbell
2015-08-14 15:19 ` Boris Ostrovsky [this message]
2015-08-14 15:35   ` Empty memory nodes in VNUMA Wei Liu
2015-08-14 15:38     ` Boris Ostrovsky
2015-08-14 15:44       ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55CE0719.9000608@oracle.com \
    --to=boris.ostrovsky@oracle.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=dario.faggioli@citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).