From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Ostrovsky Subject: Empty memory nodes in VNUMA Date: Fri, 14 Aug 2015 11:19:53 -0400 Message-ID: <55CE0719.9000608@oracle.com> References: <1439480480-20939-1-git-send-email-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZQGmn-0004EQ-Fh for xen-devel@lists.xenproject.org; Fri, 14 Aug 2015 15:20:49 +0000 In-Reply-To: <1439480480-20939-1-git-send-email-wei.liu2@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu , Dario Faggioli Cc: Xen-devel , Ian Jackson , Ian Campbell List-Id: xen-devel@lists.xenproject.org What is the purpose of 'nr_vmemranges < nr_vnodes' test in xc_domain_setvnuma()? Can't we have nodes with no memory? If that's the case, this check will still miss configurations when a node spans multiple memory ranges. For example, this fails: vcpus = 4 vnuma = [ [ "pnode=0","size=2048","vcpus=0-1" ], [ "pnode=1","size=1800" ], [ "pnode=2","size=0","vcpus=2-3" ], [ "pnode=3","size=100" ] ] but this vcpus = 4 vnuma = [ [ "pnode=0","size=2048","vcpus=0-1" ], [ "pnode=1","size=1801" ], [ "pnode=2","size=0","vcpus=2-3" ], [ "pnode=3","size=100" ] ] does not: because of MMIO hole this will cause a second 1MB range to be created on node 1 (in libxl__vnuma_build_vmemrange_hvm()). Can we drop this check? -boris