From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Ostrovsky Subject: Re: [PATCH for-4.6] xl/vNUMA: Allow empty memory nodes Date: Fri, 14 Aug 2015 13:30:33 -0400 Message-ID: <55CE25B9.1040100@oracle.com> References: <1439569132-18697-1-git-send-email-boris.ostrovsky@oracle.com> <20150814162601.GM978@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZQIpJ-0003pQ-Qd for xen-devel@lists.xenproject.org; Fri, 14 Aug 2015 17:31:33 +0000 In-Reply-To: <20150814162601.GM978@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: xen-devel@lists.xenproject.org, dario.faggioli@citrix.com, Ian.Jackson@eu.citrix.com, ian.campbell@citrix.com List-Id: xen-devel@lists.xenproject.org On 08/14/2015 12:26 PM, Wei Liu wrote: > This title should say "libxc: ..." Ah, of course. Let me know if you want me to re-send it. -boris > > On Fri, Aug 14, 2015 at 12:18:52PM -0400, Boris Ostrovsky wrote: >> The test for 'nr_vmemranges < nr_vnodes' in xc_domain_setvnuma() was >> originally writtten with the idea that number of memory ranges would >> at least be equal to number of nodes. >> >> We may want to specify nodes with no memory, however, and thus this >> check should be removed. >> >> Signed-off-by: Boris Ostrovsky > Acked-by: Wei Liu > > With my RM hat on, because libxl, hypervisor and hvmloader can already > cope with 0 vmemrange configuration, removing this restriction is safe. > > Release-acked-by: Wei Liu > >> --- >> tools/libxc/xc_domain.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/tools/libxc/xc_domain.c b/tools/libxc/xc_domain.c >> index 2ee26fb..780797f 100644 >> --- a/tools/libxc/xc_domain.c >> +++ b/tools/libxc/xc_domain.c >> @@ -2451,8 +2451,7 @@ int xc_domain_setvnuma(xc_interface *xch, >> XC_HYPERCALL_BUFFER_BOUNCE_BOTH); >> errno = EINVAL; >> >> - if ( nr_vnodes == 0 || nr_vmemranges == 0 || >> - nr_vmemranges < nr_vnodes || nr_vcpus == 0 ) >> + if ( nr_vnodes == 0 || nr_vmemranges == 0 || nr_vcpus == 0 ) >> return -1; >> >> if ( !vdistance || !vcpu_to_vnode || !vmemrange || !vnode_to_pnode ) >> -- >> 1.9.3