From: Julien Grall <julien.grall@citrix.com>
To: "Chris (Christopher) Brand" <chris.brand@broadcom.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Cc: "stefano.stabellini@citrix.com" <stefano.stabellini@citrix.com>,
"Ian Campbell (ian.campbell@citrix.com)"
<ian.campbell@citrix.com>
Subject: Re: [PATCH 1/2] xen: arm re-order assignments in mfn_to_xen_entry()
Date: Mon, 17 Aug 2015 11:24:55 -0700 [thread overview]
Message-ID: <55D226F7.1010708@citrix.com> (raw)
In-Reply-To: <4EE5B48738DDED408878C97C8E050A8B1D7EC7DE@SJEXCHMB05.corp.ad.broadcom.com>
Hi Chris,
On 14/08/2015 14:41, Chris (Christopher) Brand wrote:
> Shuffle lines around so that the assignments in mfn_to_xen_entry()
> occur in the same order as the bits are declared in lpae_pt_t.
> This makes it easier to see which ones are never given a value.
> No change in behaviour.
>
> Also fix a minor comment typo.
>
> Signed-off-by: Chris Brand <chris.brand@broadcom.com>
Reviewed-by: Julien Grall <julien.grall@citrix.com>
Regards,
--
Julien Grall
prev parent reply other threads:[~2015-08-17 18:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-14 21:41 [PATCH 1/2] xen: arm re-order assignments in mfn_to_xen_entry() Chris (Christopher) Brand
2015-08-17 18:24 ` Julien Grall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55D226F7.1010708@citrix.com \
--to=julien.grall@citrix.com \
--cc=chris.brand@broadcom.com \
--cc=ian.campbell@citrix.com \
--cc=stefano.stabellini@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).