From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: Design doc of adding ACPI support for arm64 on Xen - version 3 Date: Mon, 17 Aug 2015 23:36:14 -0700 Message-ID: <55D2D25E.7020509@citrix.com> References: <55CE0247.4030805@linaro.org> <55CE06A5.8050307@citrix.com> <55D1DB2D.6050807@linaro.org> <55D20788.9050503@citrix.com> <55D2A445.5020405@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <55D2A445.5020405@huawei.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Shannon Zhao , Shannon Zhao , xen-devel@lists.xen.org, Christoffer Dall , Ian Campbell , stefano.stabellini@eu.citrix.com, Stefano Stabellini , JBeulich@suse.com, Parth Dixit , andrew@fubar.geek.nz, boris.ostrovsky@oracle.com, david.vrabel@citrix.com Cc: Hangaohuai , "Huangpeng (Peter)" List-Id: xen-devel@lists.xenproject.org On 17/08/2015 20:19, Shannon Zhao wrote: >>> Yes, I think it's good to drop the "linux," too. But if we drop the >>> linux, would it impact the linux kernel booting with UEFI? And why we >>> don't do it to Xen since Xen still uses "linux,"? >> >> I don't understand your second question. >> > I mean that Xen is using the property "linux,uefi*" as well, and why we > don't drop that prefix for Xen? As never say we shouldn't drop it in Xen... It's of course a nice clean up to have if we ever happen to standardize the properties with a different name. >> For the first question, as we discussed in several mail, the property >> "linux,uefi-*" are only used internally between the stub and Linux. The >> sub is compiled in the kernel so there is no issue to change the property. >> > Since Linux defines the dt_params like below which is used to get EFI > info from DT, if we drop "linux," in Xen, does it need to drop the > "linux," in dt_params? If so, will this break the compatibility of > changed kernel with old UEFI? IIUC, there is not only Xen using these > properties, but also native host and QEMU guest. I grepped "linux," and didn't spot any "linux,uefi-*" strings. Anyway, why are you speaking about old UEFI? As said in different mail, the linux,uefi-* properties are only used internally between the EFI stub and the kernel. Both are living in the same binary so it's not exposed outside. Those properties are not standardize so it would be wrong to use them to talk to the kernel. Note that on Xen, we also used them internally. They were name "linux,uefi-*" because we re-use a part of the EFI stub from Linux. The names don't matter, so we can rename it without any issue Regards, -- Julien Grall