From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH v5 26/28] libxc/xen: introduce a start info structure for HVMlite guests Date: Fri, 21 Aug 2015 22:00:20 +0100 Message-ID: <55D79164.6020205@citrix.com> References: <1440176021-18910-1-git-send-email-roger.pau@citrix.com> <1440176021-18910-27-git-send-email-roger.pau@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZStQH-0008Kp-N0 for xen-devel@lists.xenproject.org; Fri, 21 Aug 2015 21:00:25 +0000 In-Reply-To: <1440176021-18910-27-git-send-email-roger.pau@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Roger Pau Monne , xen-devel@lists.xenproject.org Cc: Wei Liu , Ian Jackson , Ian Campbell , Jan Beulich , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org T24gMjEvMDgvMTUgMTc6NTMsIFJvZ2VyIFBhdSBNb25uZSB3cm90ZToKPiBUaGlzIHN0cnVjdHVy ZSBjb250YWlucyB0aGUgcGh5c2ljYWwgYWRkcmVzcyBvZiB0aGUgY29tbWFuZCBsaW5lLCBhcyB3 ZWxsIGFzCj4gdGhlIHBoeXNpY2FsIGFkZHJlc3Mgb2YgdGhlIGxpc3Qgb2YgbG9hZGVkIG1vZHVs ZXMuIFRoZSBwaHlzaWNhbCBhZGRyZXNzIG9mCj4gdGhpcyBzdHJ1Y3R1cmUgaXMgcGFzc2VkIHRv IHRoZSBndWVzdCBhdCBib290IHRpbWUgaW4gdGhlICVlYnggcmVnaXN0ZXIuCj4KPiBTaWduZWQt b2ZmLWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4KPiBDYzogSWFu IEphY2tzb24gPGlhbi5qYWNrc29uQGV1LmNpdHJpeC5jb20+Cj4gQ2M6IFN0ZWZhbm8gU3RhYmVs bGluaSA8c3RlZmFuby5zdGFiZWxsaW5pQGV1LmNpdHJpeC5jb20+Cj4gQ2M6IElhbiBDYW1wYmVs bCA8aWFuLmNhbXBiZWxsQGNpdHJpeC5jb20+Cj4gQ2M6IFdlaSBMaXUgPHdlaS5saXUyQGNpdHJp eC5jb20+Cj4gQ2M6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4KPiBDYzogQW5kcmV3 IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4KClRoaXMgbG9va3MgbXVjaCBuaWNl ciB0aGFuIHRoZSBwcmV2aW91cyBtZXRob2QuICBBIGZldyBjb21tZW50cy4KCj4gLS0tCj4gIHRv b2xzL2xpYnhjL3hjX2RvbV94ODYuYyB8IDYwICsrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrLQo+ICB4ZW4vaW5jbHVkZS9wdWJsaWMveGVuLmggfCAxOSArKysr KysrKysrKysrKysKPiAgMiBmaWxlcyBjaGFuZ2VkLCA3OCBpbnNlcnRpb25zKCspLCAxIGRlbGV0 aW9uKC0pCj4KPiBkaWZmIC0tZ2l0IGEvdG9vbHMvbGlieGMveGNfZG9tX3g4Ni5jIGIvdG9vbHMv bGlieGMveGNfZG9tX3g4Ni5jCj4gaW5kZXggZmI3MTcxNy4uM2I0MGJhMSAxMDA2NDQKPiAtLS0g YS90b29scy9saWJ4Yy94Y19kb21feDg2LmMKPiArKysgYi90b29scy9saWJ4Yy94Y19kb21feDg2 LmMKPiBAQCAtNTYwLDcgKzU2MCw2MiBAQCBzdGF0aWMgaW50IGFsbG9jX21hZ2ljX3BhZ2VzX2h2 bShzdHJ1Y3QgeGNfZG9tX2ltYWdlICpkb20pCj4gICAgICB4Y19odm1fcGFyYW1fc2V0KHhjaCwg ZG9taWQsIEhWTV9QQVJBTV9TSEFSSU5HX1JJTkdfUEZOLAo+ICAgICAgICAgICAgICAgICAgICAg ICBzcGVjaWFsX3BmbihTUEVDSUFMUEFHRV9TSEFSSU5HKSk7Cj4gIAo+IC0gICAgaWYgKCBkb20t PmRldmljZV9tb2RlbCApCj4gKyAgICBpZiAoICFkb20tPmRldmljZV9tb2RlbCApCj4gKyAgICB7 Cj4gKyAgICAgICAgc3RydWN0IHhjX2RvbV9zZWcgc2VnOwo+ICsgICAgICAgIHN0cnVjdCBodm1f c3RhcnRfaW5mbyAqc3RhcnRfaW5mbzsKPiArICAgICAgICBjaGFyICpjbWRsaW5lOwo+ICsgICAg ICAgIHN0cnVjdCBodm1fbW9kbGlzdF9lbnRyeSAqbW9kbGlzdDsKPiArICAgICAgICB2b2lkICpz dGFydF9wYWdlOwo+ICsgICAgICAgIHNpemVfdCBjbWRsaW5lX3NpemUgPSBkb20tPmNtZGxpbmUg PyBzdHJsZW4oZG9tLT5jbWRsaW5lKSArIDEgOiAwOwo+ICsgICAgICAgIHNpemVfdCBzdGFydF9p bmZvX3NpemUgPSBzaXplb2YoKnN0YXJ0X2luZm8pICsgY21kbGluZV9zaXplICsKCkkgd291bGQg cm91bmQgY21kbGluZV9zaXplIHVwIHRvIHRoZSBuZWFyZXN0IDgsIHRvIGFsaWduIHRoZSBtb2Rs aXN0LgoKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZG9tLT5yYW1kaXNrX2Js b2IgPyBzaXplb2YoKm1vZGxpc3QpCgpzaXplb2YoKm1vZGxpc3QpICogbnJfZW50cmllcy4KClRo aXMgY3VycmVudGx5IHdvcmtzIGJlY2F1c2UgdGhlcmUgaXMgb25seSBldmVyIG9uZSBleHRyYSBi bG9iLCBidXQgd2lsbApiZSB3cm9uZyBpbiB0aGUgZnV0dXJlIHdoZW4gd2Ugd2FudCB0byBwYXNz IG90aGVyIGJsb2JzLiAgKEkgaGF2ZSBzb21lCnBsYW5zIHRvIGZpeCB0aGUgY3VycmVudCByZXF1 aXJlbWVudHMgdG8gYnVpbGQgc2VhYmlvcyBpbnRvIGh2bWxvYWRlciwKYW5kIG1ha2UgaXQgcG9z c2libGUgdG8gcGFzcyB0aGluZ3MgbGlrZSBOVlJBTSBibG9icy4pCgo+ICA6IDA7CgpJIHdvdWxk IHN1Z2dlc3Q6CgpzaXplX3Qgc3RhcnRfaW5mb19zaXplID0gc2l6ZW9mKCpzdGFydF9pbmZvKTsK aWYgKCBkb20tPmNtZGxpbmUgKQogICAgc3RhcnRfaW5mb19zaXplICs9IFJPVU5EVVAoc3RybGVu KGRvbS0+Y21kbGluZSkgKyAxLCA4KTsKaWYgKCBkb20tPnJhbWRpc2tfYmxvYiApCiAgICBzdGFy dF9pbmZvX3NpemUgKz0gc2l6ZW9mKCptb2RsaXN0KTsgLyogT25seSBvbmUgbW9kdWxlIGF0IHRo ZQptb21lbnQuICovCgpBcyBhIGNsZWFyZXIgd2F5IG9mIGV4cHJlc3NpbmcgdGhlIGxvZ2ljLgoK PiArCj4gKyAgICAgICAgcmMgPSB4Y19kb21fYWxsb2Nfc2VnbWVudChkb20sICZzZWcsICJIVk1s aXRlIHN0YXJ0IGluZm8iLCAwLAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg c3RhcnRfaW5mb19zaXplKTsKPiArICAgICAgICBpZiAoIHJjICE9IDAgKQo+ICsgICAgICAgIHsK PiArICAgICAgICAgICAgRE9NUFJJTlRGKCJVbmFibGUgdG8gcmVzZXJ2ZSBtZW1vcnkgZm9yIHRo ZSBzdGFydCBpbmZvIik7Cj4gKyAgICAgICAgICAgIGdvdG8gb3V0Owo+ICsgICAgICAgIH0KPiAr Cj4gKyAgICAgICAgc3RhcnRfcGFnZSA9IHhjX21hcF9mb3JlaWduX3JhbmdlKHhjaCwgZG9taWQs IHN0YXJ0X2luZm9fc2l6ZSwKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgUFJPVF9SRUFEIHwgUFJPVF9XUklURSwKPiArICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgc2VnLnBmbik7Cj4gKyAgICAgICAgaWYgKCBzdGFydF9wYWdlID09 IE5VTEwgKQo+ICsgICAgICAgIHsKPiArICAgICAgICAgICAgRE9NUFJJTlRGKCJVbmFibGUgdG8g bWFwIEhWTSBzdGFydCBpbmZvIHBhZ2UiKTsKPiArICAgICAgICAgICAgZ290byBlcnJvcl9vdXQ7 Cj4gKyAgICAgICAgfQo+ICsKPiArICAgICAgICBzdGFydF9pbmZvID0gc3RhcnRfcGFnZTsKPiAr ICAgICAgICBjbWRsaW5lID0gc3RhcnRfcGFnZSArIHNpemVvZigqc3RhcnRfaW5mbyk7Cj4gKyAg ICAgICAgbW9kbGlzdCA9IHN0YXJ0X3BhZ2UgKyBzaXplb2YoKnN0YXJ0X2luZm8pICsgY21kbGlu ZV9zaXplOwo+ICsKPiArICAgICAgICBpZiAoIGRvbS0+Y21kbGluZSApCj4gKyAgICAgICAgewo+ ICsgICAgICAgICAgICBzdHJuY3B5KGNtZGxpbmUsIGRvbS0+Y21kbGluZSwgTUFYX0dVRVNUX0NN RExJTkUpOwo+ICsgICAgICAgICAgICBjbWRsaW5lW01BWF9HVUVTVF9DTURMSU5FIC0gMV0gPSAn XDAnOwo+ICsgICAgICAgICAgICBzdGFydF9pbmZvLT5jbWRsaW5lX3BhZGRyID0gKHNlZy5wZm4g PDwgUEFHRV9TSElGVCkgKwo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgc2l6ZW9mKCpzdGFydF9pbmZvKTsKCkFzIHRoZSBsYXlvdXQgc3RhcnRzIHRvIGdldCBtb3Jl IGNvbXBsaWNhdGVkLCB0aGlzIHN0eWxlIG9mIGNhbGN1bGF0aW9uCndvdWxkIGJlIGNsZWFuZXIg YXMKCihzZWcucGZuIDw8IFBBR0VfU0hJRlQpICsgKGNtZGxpbmUgLSBzdGFydF9pbmZvKTsKCj4g KyAgICAgICAgfQo+ICsKPiArICAgICAgICBpZiAoIGRvbS0+cmFtZGlza19ibG9iICkKPiArICAg ICAgICB7Cj4gKyAgICAgICAgICAgIG1vZGxpc3RbMF0ucGFkZHIgPSBkb20tPnJhbWRpc2tfc2Vn LnZzdGFydCAtIGRvbS0+cGFybXMudmlydF9iYXNlOwo+ICsgICAgICAgICAgICBtb2RsaXN0WzBd LnNpemUgPSBkb20tPnJhbWRpc2tfc2VnLnZlbmQgLSBkb20tPnJhbWRpc2tfc2VnLnZzdGFydDsK PiArICAgICAgICAgICAgc3RhcnRfaW5mby0+bW9kbGlzdF9wYWRkciA9IChzZWcucGZuIDw8IFBB R0VfU0hJRlQpICsKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHNp emVvZigqc3RhcnRfaW5mbykgKyBjbWRsaW5lX3NpemU7Cj4gKyAgICAgICAgICAgIHN0YXJ0X2lu Zm8tPm5yX21vZHVsZXMgPSAxOwo+ICsgICAgICAgIH0KPiArCj4gKyAgICAgICAgc3RhcnRfaW5m by0+bWFnaWMgPSBIVk1fU1RBUlRfTUFHSUNfVkFMVUU7Cj4gKwo+ICsgICAgICAgIG11bm1hcChz dGFydF9wYWdlLCBzdGFydF9pbmZvX3NpemUpOwo+ICsKPiArICAgICAgICBkb20tPnN0YXJ0X2lu Zm9fcGZuID0gc2VnLnBmbjsKPiArICAgIH0KPiArICAgIGVsc2UKPiAgICAgIHsKPiAgICAgICAg ICAvKgo+ICAgICAgICAgICAqIEFsbG9jYXRlIGFuZCBjbGVhciBhZGRpdGlvbmFsIGlvcmVxIHNl cnZlciBwYWdlcy4gVGhlIGRlZmF1bHQKPiBAQCAtOTE2LDYgKzk3MSw5IEBAIHN0YXRpYyBpbnQg dmNwdV9odm0oc3RydWN0IHhjX2RvbV9pbWFnZSAqZG9tKQo+ICAgICAgLyogU2V0IHRoZSBJUC4g Ki8KPiAgICAgIGJzcF9jdHguY3B1LnJpcCA9IGRvbS0+cGFybXMucGh5c19lbnRyeTsKPiAgCj4g KyAgICBpZiAoIGRvbS0+c3RhcnRfaW5mb19wZm4gKQo+ICsgICAgICAgIGJzcF9jdHguY3B1LnJi eCA9IGRvbS0+c3RhcnRfaW5mb19wZm4gPDwgUEFHRV9TSElGVDsKPiArCj4gICAgICAvKiBTZXQg dGhlIGVuZCBkZXNjcmlwdG9yLiAqLwo+ICAgICAgYnNwX2N0eC5lbmRfZC50eXBlY29kZSA9IEhW TV9TQVZFX0NPREUoRU5EKTsKPiAgICAgIGJzcF9jdHguZW5kX2QuaW5zdGFuY2UgPSAwOwo+IGRp ZmYgLS1naXQgYS94ZW4vaW5jbHVkZS9wdWJsaWMveGVuLmggYi94ZW4vaW5jbHVkZS9wdWJsaWMv eGVuLmgKPiBpbmRleCBmZjU1NDdlLi5jYTZhMDY2IDEwMDY0NAo+IC0tLSBhL3hlbi9pbmNsdWRl L3B1YmxpYy94ZW4uaAo+ICsrKyBiL3hlbi9pbmNsdWRlL3B1YmxpYy94ZW4uaAo+IEBAIC03ODQs NiArNzg0LDI1IEBAIHN0cnVjdCBzdGFydF9pbmZvIHsKPiAgfTsKPiAgdHlwZWRlZiBzdHJ1Y3Qg c3RhcnRfaW5mbyBzdGFydF9pbmZvX3Q7Cj4gIAo+ICsvKgo+ICsgKiBTdGFydCBvZiBkYXkgc3Ry dWN0dXJlIHBhc3NlZCB0byBIVk1saXRlIGd1ZXN0cyBpbiAlZWJ4LgoKQXMgd2UgYXJlIHBsYW5u aW5nIHRvIHJlbmFtZSBIVk1saXRlIHRvIFBWSCwgSSB3b3VsZCBhdm9pZCB0aGUgdXNlIG9mCkhW TWxpdGUgaW4gY29tbWl0dGVkIGNvZGUuCgpBbHNvIGFzIHRoaXMgaXMgSFZNIHNwZWNpZmljLCBt aWdodCBpdCBiZSBiZXR0ZXIgaW4gcHVibGljL2h2bT8gIEkgZ3Vlc3MKdGhhdCBkZXBlbmRzIG9u IHdoZXRoZXIgQVJNIGlzIGxpa2VseSB0byB1c2UgaXQuCgp+QW5kcmV3Cgo+ICsgKi8KPiArc3Ry dWN0IGh2bV9zdGFydF9pbmZvIHsKPiArI2RlZmluZSBIVk1fU1RBUlRfTUFHSUNfVkFMVUUgMHgz MzZlYzU3OAo+ICsgICAgdWludDMyX3QgbWFnaWM7ICAgICAgICAgICAgIC8qIENvbnRhaW5zIHRo ZSBtYWdpYyB2YWx1ZSAweDMzNmVjNTc4ICAgICAgICovCj4gKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgLyogKCJ4RW4zIiB3aXRoIHRoZSAweDgwIGJpdCBvZiB0aGUgIkUiIHNldCku Ki8KPiArICAgIHVpbnQzMl90IGZsYWdzOyAgICAgICAgICAgICAvKiBTSUZfeHh4IGZsYWdzLiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAqLwo+ICsgICAgdWludDMyX3QgY21kbGluZV9wYWRk cjsgICAgIC8qIFBoeXNpY2FsIGFkZHJlc3Mgb2YgdGhlIGNvbW1hbmQgbGluZS4gICAgICovCj4g KyAgICB1aW50MzJfdCBucl9tb2R1bGVzOyAgICAgICAgLyogTnVtYmVyIG9mIG1vZHVsZXMgcGFz c2VkIHRvIHRoZSBrZXJuZWwuICAgKi8KPiArICAgIHVpbnQzMl90IG1vZGxpc3RfcGFkZHI7ICAg ICAvKiBQaHlzaWNhbCBhZGRyZXNzIG9mIGFuIGFycmF5IG9mICAgICAgICAgICAqLwo+ICsgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIC8qIGh2bV9tb2RsaXN0X2VudHJ5LiAgICAgICAg ICAgICAgICAgICAgICAgICovCj4gK307Cj4gKwo+ICtzdHJ1Y3QgaHZtX21vZGxpc3RfZW50cnkg ewo+ICsgICAgdWludDY0X3QgcGFkZHI7ICAgICAgICAgICAgIC8qIFBoeXNpY2FsIGFkZHJlc3Mg b2YgdGhlIG1vZHVsZS4gICAgICAgICAgICovCj4gKyAgICB1aW50NjRfdCBzaXplOyAgICAgICAg ICAgICAgLyogU2l6ZSBvZiB0aGUgbW9kdWxlIGluIGJ5dGVzLiAgICAgICAgICAgICAgKi8KPiAr fTsKPiArCj4gIC8qIE5ldyBjb25zb2xlIHVuaW9uIGZvciBkb20wIGludHJvZHVjZWQgaW4gMHgw MDAzMDIwMy4gKi8KPiAgI2lmIF9fWEVOX0lOVEVSRkFDRV9WRVJTSU9OX18gPCAweDAwMDMwMjAz Cj4gICNkZWZpbmUgY29uc29sZV9tZm4gICAgY29uc29sZS5kb21VLm1mbgoKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxp c3QKWGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0cDovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVs Cg==