From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= Subject: Re: [PATCH v5 26/28] libxc/xen: introduce a start info structure for HVMlite guests Date: Mon, 24 Aug 2015 17:24:41 +0200 Message-ID: <55DB3739.8000101@citrix.com> References: <1440176021-18910-1-git-send-email-roger.pau@citrix.com> <1440176021-18910-27-git-send-email-roger.pau@citrix.com> <55D79164.6020205@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZTtcZ-0008I6-In for xen-devel@lists.xenproject.org; Mon, 24 Aug 2015 15:25:15 +0000 In-Reply-To: <55D79164.6020205@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper , xen-devel@lists.xenproject.org Cc: Wei Liu , Ian Jackson , Ian Campbell , Jan Beulich , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org El 21/08/15 a les 23.00, Andrew Cooper ha escrit: > On 21/08/15 17:53, Roger Pau Monne wrote: >> --- a/xen/include/public/xen.h >> +++ b/xen/include/public/xen.h >> @@ -784,6 +784,25 @@ struct start_info { >> }; >> typedef struct start_info start_info_t; >> >> +/* >> + * Start of day structure passed to HVMlite guests in %ebx. > > As we are planning to rename HVMlite to PVH, I would avoid the use of > HVMlite in committed code. > > Also as this is HVM specific, might it be better in public/hvm? I guess > that depends on whether ARM is likely to use it. I don't have an opinion on this, I just placed it where it seemed more natural to me, which is after the classic PV start_info definition. Roger.