Re: [PATCH v5 07/28] libxc: rework BSP initialization

[Andrew Cooper <andrew.cooper3@citrix.com>]

On 25/08/15 10:22, Roger Pau Monné wrote:
> El 25/08/15 a les 11.02, Wei Liu ha escrit:
>> On Fri, Aug 21, 2015 at 06:53:20PM +0200, Roger Pau Monne wrote:
>> [...]
>>>  static int clear_page(struct xc_dom_image *dom, xen_pfn_t pfn)
>>>  {
>>>      xen_pfn_t dst;
>>> @@ -197,14 +184,9 @@ void *xc_dom_boot_domU_map(struct xc_dom_image *dom, xen_pfn_t pfn,
>>>  
>>>  int xc_dom_boot_image(struct xc_dom_image *dom)
>>>  {
>>> -    DECLARE_HYPERCALL_BUFFER(vcpu_guest_context_any_t, ctxt);
>>>      xc_dominfo_t info;
>>>      int rc;
>>>  
>>> -    ctxt = xc_hypercall_buffer_alloc(dom->xch, ctxt, sizeof(*ctxt));
>>> -    if ( ctxt == NULL )
>>> -        return -1;
>>> -
>> As I said in my last round review, I think you would need to use the
>> same snippet to allocate hypercall safe buffer in various vcpu_*
>> functions.
>>
>> Is there any reason that you don't do it in this version?
> I've already replied to your comment in the previous version and I
> thought you agreed on the explanation (since there was no further reply):
>
> http://marc.info/?l=xen-devel&m=143894912832281

I concur.  xc_vcpu_setcontext() does correctly bounce buffer the array.

Both the x86 and arm paths look correct.

~Andrew