From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v5 07/28] libxc: rework BSP initialization
Date: Tue, 25 Aug 2015 10:35:04 +0100
Message-ID: <55DC36C8.6070505@citrix.com>
References: <1440176021-18910-1-git-send-email-roger.pau@citrix.com>
	<1440176021-18910-8-git-send-email-roger.pau@citrix.com>
	<20150825090257.GG29776@zion.uk.xensource.com>
	<55DC33C8.1030304@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=672c3284e=Andrew.Cooper3@citrix.com>)
	id 1ZUAdL-0002yP-Rz
	for xen-devel@lists.xenproject.org; Tue, 25 Aug 2015 09:35:11 +0000
In-Reply-To: <55DC33C8.1030304@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: =?windows-1252?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>, Wei Liu <wei.liu2@citrix.com>
Cc: xen-devel@lists.xenproject.org, Ian Jackson <ian.jackson@eu.citrix.com>, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 25/08/15 10:22, Roger Pau Monn=E9 wrote:
> El 25/08/15 a les 11.02, Wei Liu ha escrit:
>> On Fri, Aug 21, 2015 at 06:53:20PM +0200, Roger Pau Monne wrote:
>> [...]
>>>  static int clear_page(struct xc_dom_image *dom, xen_pfn_t pfn)
>>>  {
>>>      xen_pfn_t dst;
>>> @@ -197,14 +184,9 @@ void *xc_dom_boot_domU_map(struct xc_dom_image *do=
m, xen_pfn_t pfn,
>>>  =

>>>  int xc_dom_boot_image(struct xc_dom_image *dom)
>>>  {
>>> -    DECLARE_HYPERCALL_BUFFER(vcpu_guest_context_any_t, ctxt);
>>>      xc_dominfo_t info;
>>>      int rc;
>>>  =

>>> -    ctxt =3D xc_hypercall_buffer_alloc(dom->xch, ctxt, sizeof(*ctxt));
>>> -    if ( ctxt =3D=3D NULL )
>>> -        return -1;
>>> -
>> As I said in my last round review, I think you would need to use the
>> same snippet to allocate hypercall safe buffer in various vcpu_*
>> functions.
>>
>> Is there any reason that you don't do it in this version?
> I've already replied to your comment in the previous version and I
> thought you agreed on the explanation (since there was no further reply):
>
> http://marc.info/?l=3Dxen-devel&m=3D143894912832281

I concur.  xc_vcpu_setcontext() does correctly bounce buffer the array.

Both the x86 and arm paths look correct.

~Andrew