From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH v2 4/8] tmem: Remove xc_tmem_control mystical arg3 Date: Thu, 27 Aug 2015 13:53:17 +0100 Message-ID: <55DF083D.3060905@citrix.com> References: <1440673323-6648-1-git-send-email-konrad.wilk@oracle.com> <1440673323-6648-5-git-send-email-konrad.wilk@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZUwgD-0003I5-CF for xen-devel@lists.xenproject.org; Thu, 27 Aug 2015 12:53:21 +0000 In-Reply-To: <1440673323-6648-5-git-send-email-konrad.wilk@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Rzeszutek Wilk , xen-devel@lists.xenproject.org, jbeulich@suse.com, wei.liu2@citrix.com List-Id: xen-devel@lists.xenproject.org On 27/08/15 12:01, Konrad Rzeszutek Wilk wrote: > It mentions it but it is never used. The hypercall interface > knows nothing of this sort of thing either. Lets just remove it. > > Signed-off-by: Konrad Rzeszutek Wilk It would be nice if you could take the opportunity of changing every caller to fix the style issues in affected code. There are a huge number of missing spaces in the parameter lists of calls to xc_tmem_control() ~Andrew