xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	xen-devel@lists.xenproject.org, jbeulich@suse.com,
	wei.liu2@citrix.com
Subject: Re: [PATCH v2 7/8] tmem: Remove extra spaces at end and some hard tabbing.
Date: Thu, 27 Aug 2015 14:19:25 +0100	[thread overview]
Message-ID: <55DF0E5D.7000409@citrix.com> (raw)
In-Reply-To: <1440673323-6648-8-git-send-email-konrad.wilk@oracle.com>

On 27/08/15 12:02, Konrad Rzeszutek Wilk wrote:
> @@ -1559,7 +1559,7 @@ refind:
>          {
>              /* no puts allowed into a frozen pool (except dup puts) */
>              if ( client->frozen )
> -	        goto unlock_obj;
> +	            goto unlock_obj;

Need to lose 3 spaces here.

>          }
>      }
>      else
> @@ -1572,10 +1572,10 @@ refind:
>  
>          write_lock(&pool->pool_rwlock);
>          /*
> -	 * Parallel callers may already allocated obj and inserted to obj_rb_root
> -	 * before us.
> -	 */
> -        if (!obj_rb_insert(&pool->obj_rb_root[oid_hash(oidp)], obj))
> +         * Parallel callers may already allocated obj and inserted to obj_rb_root
> +         * before us.
> +         */
> +        if ( !obj_rb_insert(&pool->obj_rb_root[oid_hash(oidp)], obj) )
>          {
>              tmem_free(obj, pool);
>              write_unlock(&pool->pool_rwlock);
> @@ -1945,7 +1945,7 @@ static int do_tmem_new_pool(domid_t this_cli_id,
>                       (client->shared_auth_uuid[i][1] == uuid_hi) )
>                      break;
>              if ( i == MAX_GLOBAL_SHARED_POOLS )
> -	    {
> +	        {

And here.

~Andrew

  reply	other threads:[~2015-08-27 13:30 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-27 11:01 [PATCH v2] Tmem bug-fixes and cleanups Konrad Rzeszutek Wilk
2015-08-27 11:01 ` [PATCH v2 1/8] tmem: Don't crash/hang/leak hypervisor when using shared pools within an guest Konrad Rzeszutek Wilk
2015-08-27 11:21   ` Wei Liu
2015-08-27 11:01 ` [PATCH v2 2/8] tmem: Add ASSERT in obj_rb_insert for pool->rwlock lock Konrad Rzeszutek Wilk
2015-08-27 14:55   ` Jan Beulich
2015-08-27 11:01 ` [PATCH v2 3/8] tmem: remove in xc_tmem_control_oid duplicate set_xen_guest_handle call Konrad Rzeszutek Wilk
2015-08-27 11:01 ` [PATCH v2 4/8] tmem: Remove xc_tmem_control mystical arg3 Konrad Rzeszutek Wilk
2015-08-27 11:15   ` Wei Liu
2015-08-27 12:53   ` Andrew Cooper
2015-08-27 18:38     ` Konrad Rzeszutek Wilk
2015-08-27 11:02 ` [PATCH v2 5/8] tmem: Move TMEM_CONTROL subop of tmem hypercall to sysctl Konrad Rzeszutek Wilk
2015-08-27 11:22   ` Wei Liu
2015-08-27 13:12   ` Andrew Cooper
2015-08-27 15:13     ` Jan Beulich
2015-08-27 18:47     ` Konrad Rzeszutek Wilk
2015-08-27 18:58       ` Andrew Cooper
2015-08-27 19:20         ` Konrad Rzeszutek Wilk
2015-08-28  8:31           ` Jan Beulich
2015-08-28 14:15         ` Konrad Rzeszutek Wilk
2015-08-28 14:40           ` Jan Beulich
2015-08-27 15:11   ` Jan Beulich
2015-08-27 18:43     ` Konrad Rzeszutek Wilk
2015-08-27 19:02       ` Andrew Cooper
2015-08-28  7:03       ` Jan Beulich
2015-08-27 11:02 ` [PATCH v2 6/8] tmem: Remove the old tmem control XSM checks as it is part of sysctl hypercall Konrad Rzeszutek Wilk
2015-08-27 20:59   ` Daniel De Graaf
2015-08-27 11:02 ` [PATCH v2 7/8] tmem: Remove extra spaces at end and some hard tabbing Konrad Rzeszutek Wilk
2015-08-27 13:19   ` Andrew Cooper [this message]
2015-08-27 11:02 ` [PATCH v2 8/8] tmem: Spelling mistakes Konrad Rzeszutek Wilk
2015-08-27 15:14   ` Jan Beulich
2015-08-27 13:30 ` [PATCH v2] Tmem bug-fixes and cleanups Andrew Cooper
2015-08-27 14:10 ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55DF0E5D.7000409@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=konrad.wilk@oracle.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).