From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH v2 7/8] tmem: Remove extra spaces at end and some hard tabbing. Date: Thu, 27 Aug 2015 14:19:25 +0100 Message-ID: <55DF0E5D.7000409@citrix.com> References: <1440673323-6648-1-git-send-email-konrad.wilk@oracle.com> <1440673323-6648-8-git-send-email-konrad.wilk@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZUxGC-0005V5-Nw for xen-devel@lists.xenproject.org; Thu, 27 Aug 2015 13:30:32 +0000 In-Reply-To: <1440673323-6648-8-git-send-email-konrad.wilk@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Rzeszutek Wilk , xen-devel@lists.xenproject.org, jbeulich@suse.com, wei.liu2@citrix.com List-Id: xen-devel@lists.xenproject.org On 27/08/15 12:02, Konrad Rzeszutek Wilk wrote: > @@ -1559,7 +1559,7 @@ refind: > { > /* no puts allowed into a frozen pool (except dup puts) */ > if ( client->frozen ) > - goto unlock_obj; > + goto unlock_obj; Need to lose 3 spaces here. > } > } > else > @@ -1572,10 +1572,10 @@ refind: > > write_lock(&pool->pool_rwlock); > /* > - * Parallel callers may already allocated obj and inserted to obj_rb_root > - * before us. > - */ > - if (!obj_rb_insert(&pool->obj_rb_root[oid_hash(oidp)], obj)) > + * Parallel callers may already allocated obj and inserted to obj_rb_root > + * before us. > + */ > + if ( !obj_rb_insert(&pool->obj_rb_root[oid_hash(oidp)], obj) ) > { > tmem_free(obj, pool); > write_unlock(&pool->pool_rwlock); > @@ -1945,7 +1945,7 @@ static int do_tmem_new_pool(domid_t this_cli_id, > (client->shared_auth_uuid[i][1] == uuid_hi) ) > break; > if ( i == MAX_GLOBAL_SHARED_POOLS ) > - { > + { And here. ~Andrew