From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH v2] Tmem bug-fixes and cleanups. Date: Thu, 27 Aug 2015 14:30:39 +0100 Message-ID: <55DF10FF.5000202@citrix.com> References: <1440673323-6648-1-git-send-email-konrad.wilk@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZUxGR-0005Wp-Kn for xen-devel@lists.xenproject.org; Thu, 27 Aug 2015 13:30:47 +0000 In-Reply-To: <1440673323-6648-1-git-send-email-konrad.wilk@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Rzeszutek Wilk , xen-devel@lists.xenproject.org, jbeulich@suse.com, wei.liu2@citrix.com List-Id: xen-devel@lists.xenproject.org On 27/08/15 12:01, Konrad Rzeszutek Wilk wrote: > Hey! > > At the Xenhackathon we spoke that the tmem code needs a bit of cleanups > and simplification. One of the things that Andrew mentioned was that the > TMEM_CONTROL should really be part of the sysctl hypercall. As I ventured > this path I realized there were some other issues that need to be taken > care of (like shared pools blowing up). > > This patchset has been tested with 32/64 guests, with a 64 hypervisor > and 32 bit toolstack (and also with 64bit toolstack) with success. > > For fun I've also created an Linux module: > http://xenbits.xen.org/gitweb/?p=xentesttools/bootstrap.git;a=blob;f=root_image/drivers/tmem_test/tmem_test.c > that I will expand to cover in the future more interesting hypercall > uses. > > Going forward the next step will be to move the 'tmem_control' function to > its own file to simplify the code. > > The patches are also in my git tree: Patches 1-4, 6-8 are definitely a net improvement, so Reviewed-by: Andrew Cooper , with the proviso that I am not knowlegable about tmem internals. ~Andrew