From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>
Cc: Keir Fraser <keir@xen.org>, Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH] x86/NUMA: fix setup_node()
Date: Fri, 28 Aug 2015 15:16:19 +0100 [thread overview]
Message-ID: <55E06D33.9010407@citrix.com> (raw)
In-Reply-To: <55E08536020000780009DD6F@prv-mh.provo.novell.com>
On 28/08/15 14:58, Jan Beulich wrote:
> The function referenced an __initdata object (nodes_found). Since this
> being a node mask was more complicated than needed, the variable gets
> replaced by a simple counter. Check at once that the count of nodes
> doesn't go beyond MAX_NUMNODES.
>
> Also consolidate four printk()s related to the function's use into just
> one.
>
> Finally (quite the opposite of the above issue) __init-annotate
> nodes_cover_memory().
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
next prev parent reply other threads:[~2015-08-28 14:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-28 13:58 [PATCH] x86/NUMA: fix setup_node() Jan Beulich
2015-08-28 14:16 ` Andrew Cooper [this message]
2015-08-31 11:46 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E06D33.9010407@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=keir@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).