From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] x86/NUMA: fix setup_node()
Date: Fri, 28 Aug 2015 15:16:19 +0100
Message-ID: <55E06D33.9010407@citrix.com>
References: <55E08536020000780009DD6F@prv-mh.provo.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=675476172=Andrew.Cooper3@citrix.com>)
	id 1ZVKSK-0005ml-RA
	for xen-devel@lists.xenproject.org; Fri, 28 Aug 2015 14:16:36 +0000
In-Reply-To: <55E08536020000780009DD6F@prv-mh.provo.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xenproject.org>
Cc: Keir Fraser <keir@xen.org>, Wei Liu <wei.liu2@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 28/08/15 14:58, Jan Beulich wrote:
> The function referenced an __initdata object (nodes_found). Since this
> being a node mask was more complicated than needed, the variable gets
> replaced by a simple counter. Check at once that the count of nodes
> doesn't go beyond MAX_NUMNODES.
>
> Also consolidate four printk()s related to the function's use into just
> one.
>
> Finally (quite the opposite of the above issue) __init-annotate
> nodes_cover_memory().
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>