xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
	xen-devel <xen-devel@lists.xenproject.org>
Cc: Keir Fraser <keir@xen.org>, Jim Fehlig <JFEHLIG@suse.com>,
	Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH] x86/NUMA: don't account hotplug regions
Date: Fri, 28 Aug 2015 15:55:02 +0100	[thread overview]
Message-ID: <55E07646.10304@citrix.com> (raw)
In-Reply-To: <55E08571020000780009DD73@prv-mh.provo.novell.com>

On 28/08/15 14:59, Jan Beulich wrote:
> ... except in cases where they really matter: node_memblk_range[] now
> is the only place all regions get stored. nodes[] and NODE_DATA() track
> present memory only. This improves the reporting when nodes have
> disjoint "normal" and hotplug regions, with the hotplug region sitting
> above the highest populated page. In such cases a node's spanned-pages
> value (visible in both XEN_SYSCTL_numainfo and 'u' debug key output)
> covered all the way up to top of populated memory, giving quite
> different a picture from what an otherwise identically configured
> system without and hotplug regions would report. Note, however, that
> the actual hotplug case (as well as cases of nodes with multiple
> disjoint present regions) is still not being handled such that the
> reported values would represent how much memory a node really has (but
> that can be considered intentional).
>
> Reported-by: Jim Fehlig <jfehlig@suse.com>
>
> This at once makes nodes_cover_memory() no longer consider E820_RAM
> regions covered by SRAT hotplug regions.
>
> Also reject self-overlaps with mismatching hotplug flags.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

  reply	other threads:[~2015-08-28 14:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-28 13:59 [PATCH] x86/NUMA: don't account hotplug regions Jan Beulich
2015-08-28 14:55 ` Andrew Cooper [this message]
2015-08-28 21:33 ` Jim Fehlig
2015-08-31 11:47 ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55E07646.10304@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=JFEHLIG@suse.com \
    --cc=keir@xen.org \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).