From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH] x86/NUMA: don't account hotplug regions Date: Fri, 28 Aug 2015 15:55:02 +0100 Message-ID: <55E07646.10304@citrix.com> References: <55E08571020000780009DD73@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZVL3y-0000Al-Ud for xen-devel@lists.xenproject.org; Fri, 28 Aug 2015 14:55:31 +0000 In-Reply-To: <55E08571020000780009DD73@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , xen-devel Cc: Keir Fraser , Jim Fehlig , Wei Liu List-Id: xen-devel@lists.xenproject.org On 28/08/15 14:59, Jan Beulich wrote: > ... except in cases where they really matter: node_memblk_range[] now > is the only place all regions get stored. nodes[] and NODE_DATA() track > present memory only. This improves the reporting when nodes have > disjoint "normal" and hotplug regions, with the hotplug region sitting > above the highest populated page. In such cases a node's spanned-pages > value (visible in both XEN_SYSCTL_numainfo and 'u' debug key output) > covered all the way up to top of populated memory, giving quite > different a picture from what an otherwise identically configured > system without and hotplug regions would report. Note, however, that > the actual hotplug case (as well as cases of nodes with multiple > disjoint present regions) is still not being handled such that the > reported values would represent how much memory a node really has (but > that can be considered intentional). > > Reported-by: Jim Fehlig > > This at once makes nodes_cover_memory() no longer consider E820_RAM > regions covered by SRAT hotplug regions. > > Also reject self-overlaps with mismatching hotplug flags. > > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper