From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@citrix.com>
Subject: Re: [PATCH v6 05/31] xen/arm: Rename NR_IRQs and
 vgic_num_irqs helper function
Date: Mon, 31 Aug 2015 15:40:05 +0100
Message-ID: <55E46745.6070709@citrix.com>
References: <1441019208-2764-1-git-send-email-vijay.kilari@gmail.com>
	<1441019208-2764-6-git-send-email-vijay.kilari@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1441019208-2764-6-git-send-email-vijay.kilari@gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: vijay.kilari@gmail.com, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com, stefano.stabellini@citrix.com, tim@xen.org, xen-devel@lists.xen.org
Cc: Prasun.Kapoor@caviumnetworks.com, Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>, manish.jaggi@caviumnetworks.com
List-Id: xen-devel@lists.xenproject.org

Hi Vijay,

On 31/08/2015 12:06, vijay.kilari@gmail.com wrote:
> From: Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>
>
> NR_IRQS define signifies number of SGIs, PPIs and SPIs.

I don' think signifies is the right word here. And I would mention that 
SGIs/PPIs/SPIs are an IRQ lines in order to make clear why we change the 
name. I.e:

"NR_IRQS represents the number of lines (i.e SGIs, PPIs and SPIs)".


> With introduction of LPIs, NR_IRQs is renamed to NR_LINE_IRQs.
       ^ the

> Similarly vgic_num_irqs() is renamed as vgic_num_line_irqs().

The proper name is "interrupt line" or "irq line" but not "line irq" 
which doesn't make sense.

So I would prefer to see NR_IRQ_LINES or NR_ITLINES. Note that the 
latter is the best given that it's the name used within the spec.

> Signed-off-by: Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>
> ---

[...]

> diff --git a/xen/include/asm-arm/irq.h b/xen/include/asm-arm/irq.h
> index f33c331..cbdc1ab 100644
> --- a/xen/include/asm-arm/irq.h
> +++ b/xen/include/asm-arm/irq.h
> @@ -19,11 +19,12 @@ struct arch_irq_desc {
>   };
>
>   #define NR_LOCAL_IRQS	32
> -#define NR_IRQS		1024
> +/* Number of SGIs+PPIs+SPIs */

Space before and after each '+'

> +#define NR_LINE_IRQS	1024
>
> -#define nr_irqs NR_IRQS
> -#define nr_static_irqs NR_IRQS
> -#define arch_hwdom_irqs(domid) NR_IRQS
> +#define nr_irqs NR_LINE_IRQS
> +#define nr_static_irqs NR_LINE_IRQS
> +#define arch_hwdom_irqs(domid) NR_LINE_IRQS

Regards,

-- 
Julien Grall