From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v6 08/31] xen/arm: ITS: Introduce msi_desc for LPIs Date: Mon, 31 Aug 2015 17:20:45 +0100 Message-ID: <55E47EDD.2090104@citrix.com> References: <1441019208-2764-1-git-send-email-vijay.kilari@gmail.com> <1441019208-2764-9-git-send-email-vijay.kilari@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1441019208-2764-9-git-send-email-vijay.kilari@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: vijay.kilari@gmail.com, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com, stefano.stabellini@citrix.com, tim@xen.org, xen-devel@lists.xen.org Cc: Prasun.Kapoor@caviumnetworks.com, Vijaya Kumar K , manish.jaggi@caviumnetworks.com List-Id: xen-devel@lists.xenproject.org Hi Vijay, On 31/08/2015 12:06, vijay.kilari@gmail.com wrote: > From: Vijaya Kumar K > > Define msi_desc structure for arm and introduce > helper functions to access msi_desc member variables. IHMO none of those helpers are useful in the code given you are only using in an handful number of places and they can't be optimized out. Most of the time, you will have 2-3 times within the same function the msi_desc. So it means 6 functions call rather than directly access the msi_desc from the irq_desc. Although, I guess we could rework later, so for now: Reviewed-by: Julien Grall Regards, -- Julien Grall