From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@citrix.com>
Subject: Re: [PATCH v6 10/31] xen/arm: ITS: Introduce gic_is_lpi
 helper function
Date: Mon, 31 Aug 2015 17:49:22 +0100
Message-ID: <55E48592.8080905@citrix.com>
References: <1441019208-2764-1-git-send-email-vijay.kilari@gmail.com>
	<1441019208-2764-11-git-send-email-vijay.kilari@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1441019208-2764-11-git-send-email-vijay.kilari@gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: vijay.kilari@gmail.com, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com, stefano.stabellini@citrix.com, tim@xen.org, xen-devel@lists.xen.org
Cc: Prasun.Kapoor@caviumnetworks.com, Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>, Zoltan Kiss <zoltan.kiss@huawei.com>, manish.jaggi@caviumnetworks.com
List-Id: xen-devel@lists.xenproject.org

Hi Vijay,

On 31/08/2015 12:06, vijay.kilari@gmail.com wrote:
> diff --git a/xen/arch/arm/gic.c b/xen/arch/arm/gic.c
> index 758678d..2199963 100644
> --- a/xen/arch/arm/gic.c
> +++ b/xen/arch/arm/gic.c
> @@ -62,6 +62,15 @@ enum gic_version gic_hw_version(void)
>      return gic_hw_ops->info->hw_version;
>   }
>
> +#ifdef HAS_GICV3
> +bool_t gic_is_lpi(unsigned int irq)
> +{
> +    return (irq >= FIRST_GIC_LPI && irq < (1 << gic_hw_ops->info->nr_id_bits));

It would make more sense to calculate the number of ID supported at boot 
time rather than re-calculate everytime this function is called (i.e 
very often).

> +}
> +#else
> +bool_t gic_is_lpi(unsigned int irq) { return 0; }
> +#endif

I though I'd already say it on a previous version. I would like to avoid 
seen any #ifdef HAS_GICV3 in the generic code include interrupt framework.

In this case, I don't see much the benefit to do a specific case for 
platform not using GICv3 (i.e ARM32).

Regards,

-- 
Julien Grall