Re: [PATCH v6 29/31] xen/arm: ITS: Map ITS translation space

[Julien Grall <julien.grall@citrix.com>]

Hi Vijay,

On 31/08/2015 12:06, vijay.kilari@gmail.com wrote:
> diff --git a/xen/arch/arm/vgic-v3-its.c b/xen/arch/arm/vgic-v3-its.c
> index 6334ca3..328c4db 100644
> --- a/xen/arch/arm/vgic-v3-its.c
> +++ b/xen/arch/arm/vgic-v3-its.c
> @@ -885,6 +885,39 @@ static const struct mmio_handler_ops vgic_gits_mmio_handler = {
>       .write_handler = vgic_v3_gits_mmio_write,
>   };
>
> +/*
> + * Map the 64K ITS translation space in guest.
> + * This is required purely for device smmu writes.
> +*/
> +
> +static int vits_map_translation_space(struct domain *d)
> +{
> +    uint64_t addr, size;
> +    int ret;
> +
> +    ASSERT(is_domain_direct_mapped(d));
> +
> +    addr = d->arch.vgic.vits->gits_base + SZ_64K;
> +    size = SZ_64K;
> +
> +    /* Using 1:1 mapping to map translation space */
> +    /* TODO: Handle DomU mapping */

I would have expected a summary of the discussion we had on the previous 
version of this patch [1] here.

This is in order to remember what needs to be done before we effectively 
implement ITS support for guest.

Regards,

[1] http://lists.xen.org/archives/html/xen-devel/2015-08/msg01704.html

-- 
Julien Grall