From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@citrix.com>
Subject: Re: [PATCH v6 29/31] xen/arm: ITS: Map ITS translation
 space
Date: Mon, 31 Aug 2015 20:07:26 +0100
Message-ID: <55E4A5EE.6030602@citrix.com>
References: <1441019208-2764-1-git-send-email-vijay.kilari@gmail.com>
	<1441019208-2764-30-git-send-email-vijay.kilari@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1441019208-2764-30-git-send-email-vijay.kilari@gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: vijay.kilari@gmail.com, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com, stefano.stabellini@citrix.com, tim@xen.org, xen-devel@lists.xen.org
Cc: Prasun.Kapoor@caviumnetworks.com, Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>, manish.jaggi@caviumnetworks.com
List-Id: xen-devel@lists.xenproject.org

Hi Vijay,

On 31/08/2015 12:06, vijay.kilari@gmail.com wrote:
> diff --git a/xen/arch/arm/vgic-v3-its.c b/xen/arch/arm/vgic-v3-its.c
> index 6334ca3..328c4db 100644
> --- a/xen/arch/arm/vgic-v3-its.c
> +++ b/xen/arch/arm/vgic-v3-its.c
> @@ -885,6 +885,39 @@ static const struct mmio_handler_ops vgic_gits_mmio_handler = {
>       .write_handler = vgic_v3_gits_mmio_write,
>   };
>
> +/*
> + * Map the 64K ITS translation space in guest.
> + * This is required purely for device smmu writes.
> +*/
> +
> +static int vits_map_translation_space(struct domain *d)
> +{
> +    uint64_t addr, size;
> +    int ret;
> +
> +    ASSERT(is_domain_direct_mapped(d));
> +
> +    addr = d->arch.vgic.vits->gits_base + SZ_64K;
> +    size = SZ_64K;
> +
> +    /* Using 1:1 mapping to map translation space */
> +    /* TODO: Handle DomU mapping */

I would have expected a summary of the discussion we had on the previous 
version of this patch [1] here.

This is in order to remember what needs to be done before we effectively 
implement ITS support for guest.

Regards,

[1] http://lists.xen.org/archives/html/xen-devel/2015-08/msg01704.html

-- 
Julien Grall