From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Dunlap <george.dunlap@citrix.com>
Subject: Re: [PATCH for 4.6] tools: Honor Config.mk debug value,
 rather than setting our own
Date: Wed, 2 Sep 2015 11:08:20 +0100
Message-ID: <55E6CA94.8070103@citrix.com>
References: <1441186495-7256-1-git-send-email-george.dunlap@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1441186495-7256-1-git-send-email-george.dunlap@eu.citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: George Dunlap <george.dunlap@eu.citrix.com>, xen-devel@lists.xen.org
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Campbell <ian.campbell@citrix.com>, Euan Harris <euan.harris@citrix.com>, Jan Beulich <JBeulich@suse.com>, Ian Jackson <ian.jackson@citrix.com>, Roger Pau Monne <roger.pau@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 09/02/2015 10:34 AM, George Dunlap wrote:
> Changeset 1166ecf ('tools/Rules.mk: Don't optimize debug builds; add
> macro debugging information') exposed a bug whereby the autoconf stuff
> in tools was setting its own debug value (defaulting to ENABLED, even
> for releases) instead of honoring the value set in Config.mk.
> 
> After that changeset, if the global build has -D_FORTIFY_SOURCE
> enabled (as is the default in CentOS 7 rpmbuild), then the tools build
> will fail (because debug builds default to on).
> 
> There should be only one place to specify whether to build debug or
> not, and Config.mk is already included by the relevant makefiles.  So
> simply remove the tools/configure debug option and everything falls
> into place naturally.
> 
> Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com>

Having debug enabled for tools by default for releases is arguably a bug
for previous releases as well, so I think this should be considered for
backport if this solution is acceptable.

 -George