From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@citrix.com>
Subject: Re: [PATCH v6 06/31] xen/arm: ITS: Port ITS driver to
 Xen
Date: Thu, 3 Sep 2015 18:02:12 +0100
Message-ID: <55E87D14.9040905@citrix.com>
References: <1441019208-2764-1-git-send-email-vijay.kilari@gmail.com>
	<1441019208-2764-7-git-send-email-vijay.kilari@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1441019208-2764-7-git-send-email-vijay.kilari@gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: vijay.kilari@gmail.com, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com, stefano.stabellini@citrix.com, tim@xen.org, xen-devel@lists.xen.org
Cc: Prasun.Kapoor@caviumnetworks.com, Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>, manish.jaggi@caviumnetworks.com
List-Id: xen-devel@lists.xenproject.org

On 31/08/15 12:06, vijay.kilari@gmail.com wrote:
> +struct its_device {
> +    /* Physical ITS */
> +    struct its_node         *its;
> +    /* Device ITT address */
> +    paddr_t                 *itt_addr;

Just spotted this, why do you have a pointer to paddr_t?

You store a pointer to the base virtual address and not the physical
address of the ITT. So the name is also wrong.

I would keep what Linux does, i.e:

void   *itt;

> +    /* Device ITT size */
> +    unsigned long           itt_size;
> +    /* LPI and event mapping */
> +    struct event_lpi_map    event_map;
> +    /* Physical Device id */
> +    u32                     device_id;
> +};

Regards,

-- 
Julien Grall