From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH for 4.6 1/5] libxc: clearer migration v2 debug message
Date: Fri, 4 Sep 2015 21:39:42 +0100 [thread overview]
Message-ID: <55EA018E.6060308@citrix.com> (raw)
In-Reply-To: <1441391531-30004-2-git-send-email-wei.liu2@citrix.com>
On 04/09/15 19:32, Wei Liu wrote:
> Previous the message was like:
>
> SAVE:
> xc: detail: 32 bits, 3 levels
> xc: detail: max_pfn 0xfffff, p2m_frames 1024
> xc: detail: max_mfn 0x130000
>
> RESTORE:
> xc: detail: max_mfn 0x130000
> xc: detail: 32 bits, 3 levels
> xc: detail: Expanded p2m from 0 to 0xfffff
>
> It's not immediately clear that the last line in restore messages was
> referring to max_pfn. Change the debug message a bit to make that
> clearer.
I am not sure that this is any clearer; the former means exactly the
same although I suppose spelling out max_pfn is more consistent with the
save side.
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
next prev parent reply other threads:[~2015-09-04 20:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-04 18:32 [PATCH for 4.6 0/5] Migration v2 fix Wei Liu
2015-09-04 18:32 ` [PATCH for 4.6 1/5] libxc: clearer migration v2 debug message Wei Liu
2015-09-04 20:39 ` Andrew Cooper [this message]
2015-09-04 18:32 ` [PATCH for 4.6 2/5] libxc: migration v2 prefix Memory -> Memory (P2M) Wei Liu
2015-09-04 20:40 ` Andrew Cooper
2015-09-04 20:50 ` Wei Liu
2015-09-04 18:32 ` [PATCH for 4.6 3/5] libxc: fix indentation Wei Liu
2015-09-04 20:41 ` Andrew Cooper
2015-09-04 18:32 ` [PATCH for 4.6 4/5] libxc: add assertion to avoid setting same bit more than once Wei Liu
2015-09-04 20:43 ` Andrew Cooper
2015-09-04 20:49 ` Wei Liu
2015-09-04 18:32 ` [PATCH for 4.6 5/5] libxc: de-duplicate gpfns in populate_pfns Wei Liu
2015-09-04 21:56 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55EA018E.6060308@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).