From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH for 4.6 1/5] libxc: clearer migration v2 debug message Date: Fri, 4 Sep 2015 21:39:42 +0100 Message-ID: <55EA018E.6060308@citrix.com> References: <1441391531-30004-1-git-send-email-wei.liu2@citrix.com> <1441391531-30004-2-git-send-email-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZXxm1-00060P-Iu for xen-devel@lists.xenproject.org; Fri, 04 Sep 2015 20:39:49 +0000 In-Reply-To: <1441391531-30004-2-git-send-email-wei.liu2@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu , Xen-devel Cc: Ian Jackson , Ian Campbell List-Id: xen-devel@lists.xenproject.org On 04/09/15 19:32, Wei Liu wrote: > Previous the message was like: > > SAVE: > xc: detail: 32 bits, 3 levels > xc: detail: max_pfn 0xfffff, p2m_frames 1024 > xc: detail: max_mfn 0x130000 > > RESTORE: > xc: detail: max_mfn 0x130000 > xc: detail: 32 bits, 3 levels > xc: detail: Expanded p2m from 0 to 0xfffff > > It's not immediately clear that the last line in restore messages was > referring to max_pfn. Change the debug message a bit to make that > clearer. I am not sure that this is any clearer; the former means exactly the same although I suppose spelling out max_pfn is more consistent with the save side. Reviewed-by: Andrew Cooper