From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH for 4.6 2/5] libxc: migration v2 prefix Memory -> Memory (P2M) Date: Fri, 4 Sep 2015 21:40:55 +0100 Message-ID: <55EA01D7.803@citrix.com> References: <1441391531-30004-1-git-send-email-wei.liu2@citrix.com> <1441391531-30004-3-git-send-email-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZXxn9-0006Ij-09 for xen-devel@lists.xenproject.org; Fri, 04 Sep 2015 20:40:59 +0000 In-Reply-To: <1441391531-30004-3-git-send-email-wei.liu2@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu , Xen-devel Cc: Ian Jackson , Ian Campbell List-Id: xen-devel@lists.xenproject.org On 04/09/15 19:32, Wei Liu wrote: > The prefix "Memory" is confusing because the numbers shown after that > are referring to P2M entries. They have no bearing on how many pages a > domain actually owns or how many actual pages are processed. > > Signed-off-by: Wei Liu > --- > tools/libxc/xc_sr_save.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/libxc/xc_sr_save.c b/tools/libxc/xc_sr_save.c > index 58667af..bb7ff54 100644 > --- a/tools/libxc/xc_sr_save.c > +++ b/tools/libxc/xc_sr_save.c > @@ -659,7 +659,7 @@ static int send_domain_memory_nonlive(struct xc_sr_context *ctx) > if ( rc ) > goto err; > > - xc_set_progress_prefix(xch, "Memory"); > + xc_set_progress_prefix(xch, "Memory (P2M)"); This is incorrect for autotranslated guests. I would recommend "Frames" instead. ~Andrew