From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH for 4.6 v2 2/5] libxc: migration v2 prefix Memory -> Frames Date: Sun, 6 Sep 2015 17:23:57 +0100 Message-ID: <55EC689D.4080902@citrix.com> References: <1441411167-32440-1-git-send-email-wei.liu2@citrix.com> <1441411167-32440-3-git-send-email-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZYcjh-0008Sa-3E for xen-devel@lists.xenproject.org; Sun, 06 Sep 2015 16:24:09 +0000 In-Reply-To: <1441411167-32440-3-git-send-email-wei.liu2@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu , Xen-devel Cc: Ian Jackson , Ian Campbell List-Id: xen-devel@lists.xenproject.org On 05/09/15 00:59, Wei Liu wrote: > The prefix "Memory" is confusing because the numbers shown after that > are referring to frames. They have no bearing on how many pages a domain > actually owns or how many actual pages are processed. There is a direct bearing on how many pages are processed, by virtue of the "$X of $Y" later in the line. I think your final phrase is misleading and should just be dropped. Also, there are two further places which need "Memory" changing in a similar way; send_memory_verify() (which itself should probably be renamed to verify_frames()), and update_progress_string() which is the companion to the hunk below, but for live migration. ~Andrew > > Signed-off-by: Wei Liu > --- > tools/libxc/xc_sr_save.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/libxc/xc_sr_save.c b/tools/libxc/xc_sr_save.c > index 58667af..924c425 100644 > --- a/tools/libxc/xc_sr_save.c > +++ b/tools/libxc/xc_sr_save.c > @@ -659,7 +659,7 @@ static int send_domain_memory_nonlive(struct xc_sr_context *ctx) > if ( rc ) > goto err; > > - xc_set_progress_prefix(xch, "Memory"); > + xc_set_progress_prefix(xch, "Frames"); > > rc = send_all_pages(ctx); > if ( rc )