From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v6 05/31] xen/arm: Rename NR_IRQs and vgic_num_irqs helper function Date: Wed, 9 Sep 2015 14:23:55 +0100 Message-ID: <55F032EB.6030404@citrix.com> References: <1441019208-2764-1-git-send-email-vijay.kilari@gmail.com> <1441019208-2764-6-git-send-email-vijay.kilari@gmail.com> <55E46745.6070709@citrix.com> <1441804088.24450.316.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1441804088.24450.316.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , vijay.kilari@gmail.com, stefano.stabellini@eu.citrix.com, stefano.stabellini@citrix.com, tim@xen.org, xen-devel@lists.xen.org Cc: Prasun.Kapoor@caviumnetworks.com, Vijaya Kumar K , manish.jaggi@caviumnetworks.com List-Id: xen-devel@lists.xenproject.org On 09/09/15 14:08, Ian Campbell wrote: > On Mon, 2015-08-31 at 15:40 +0100, Julien Grall wrote: >> [...] >>> +#define nr_irqs NR_LINE_IRQS >>> +#define nr_static_irqs NR_LINE_IRQS >>> +#define arch_hwdom_irqs(domid) NR_LINE_IRQS > > An aside: While looking at this patch I realised that all of these are used > by common code solely in relation to d->nr_pirqs. Since we don't have pirqs > on ARM really that field ought to be 0 (or even non-existent) and all of > these should then go away. nr_pirqs is used in DOMCTL_irq_permission to know the last IRQ number suported. It's working correctly domain_pirq_to_irq is an identity mapping. Regards, -- Julien Grall