From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v6 08/31] xen/arm: ITS: Introduce msi_desc for LPIs Date: Wed, 9 Sep 2015 14:28:15 +0100 Message-ID: <55F033EF.1020603@citrix.com> References: <1441019208-2764-1-git-send-email-vijay.kilari@gmail.com> <1441019208-2764-9-git-send-email-vijay.kilari@gmail.com> <1441804587.24450.319.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1441804587.24450.319.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , vijay.kilari@gmail.com, stefano.stabellini@eu.citrix.com, stefano.stabellini@citrix.com, tim@xen.org, xen-devel@lists.xen.org Cc: Prasun.Kapoor@caviumnetworks.com, vijaya.kumar@caviumnetworks.com, manish.jaggi@caviumnetworks.com List-Id: xen-devel@lists.xenproject.org On 09/09/15 14:16, Ian Campbell wrote: > On Mon, 2015-08-31 at 16:36 +0530, vijay.kilari@gmail.com wrote: >> From: Vijaya Kumar K >> >> Define msi_desc structure for arm and introduce >> helper functions to access msi_desc member variables. >> >> Signed-off-by: Vijaya Kumar K >> --- >> xen/arch/arm/gic-v3-its.c | 28 ++++++++++++++++++++++++++++ >> xen/arch/arm/irq.c | 12 ++++++++++++ >> xen/include/asm-arm/gic-its.h | 4 ++++ >> xen/include/asm-arm/irq.h | 9 +++++++++ >> 4 files changed, 53 insertions(+) >> >> diff --git a/xen/arch/arm/gic-v3-its.c b/xen/arch/arm/gic-v3-its.c >> index 88cc89d..e70c21a 100644 >> --- a/xen/arch/arm/gic-v3-its.c >> +++ b/xen/arch/arm/gic-v3-its.c >> @@ -109,6 +109,34 @@ static void dump_cmd(const its_cmd_block *cmd) >> static void dump_cmd(const its_cmd_block *cmd) { } >> #endif >> >> +void irqdesc_set_lpi_event(struct irq_desc *desc, unsigned id) > > LPIs are logically part of the GIC, not the ITS, so I think all four of > these belong at least in a gic (without -its) .c file if not in irq.c. > > Or is there a reason for them to live here? Putting those helpers in irq.c will require some #ifdery in order to not compile when GICV3 is not built. I'd like to avoid any #ifdef in the common code for ITS specific code (see irqdesc_set_its_device). Although, as I said in a previous mail, those helpers are pointless as they are only used a couple of time and always in a batch. So we should result to fetch MSI everytime we'd like to access a field. Regards, -- Julien Grall