From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Ostrovsky Subject: Re: [PATCH for 4.6 v2 3/3] xl/libxl: disallow saving a guest with vNUMA configured Date: Wed, 09 Sep 2015 13:33:15 -0400 Message-ID: <55F06D5B.50100@oracle.com> References: <1441818218-5414-1-git-send-email-wei.liu2@citrix.com> <1441818218-5414-4-git-send-email-wei.liu2@citrix.com> <55F069B4.3040206@oracle.com> <20150909172943.GD8496@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZZjGV-0004Iq-TS for xen-devel@lists.xenproject.org; Wed, 09 Sep 2015 17:34:36 +0000 In-Reply-To: <20150909172943.GD8496@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: Xen-devel , Ian Jackson , Ian Campbell , andrew.cooper3@citrix.com List-Id: xen-devel@lists.xenproject.org On 09/09/2015 01:29 PM, Wei Liu wrote: > On Wed, Sep 09, 2015 at 01:17:40PM -0400, Boris Ostrovsky wrote: >> On 09/09/2015 01:03 PM, Wei Liu wrote: >>> This is due to migration v2 frame record doesn't contain node >>> information. >>> >>> Signed-off-by: Wei Liu >>> --- >>> Cc: andrew.cooper3@citrix.com >>> --- >>> docs/man/xl.cfg.pod.5 | 2 ++ >>> tools/libxl/libxl_dom.c | 14 ++++++++++++++ >>> 2 files changed, 16 insertions(+) >>> >>> diff --git a/docs/man/xl.cfg.pod.5 b/docs/man/xl.cfg.pod.5 >>> index 80e51bb..dbd0700 100644 >>> --- a/docs/man/xl.cfg.pod.5 >>> +++ b/docs/man/xl.cfg.pod.5 >>> @@ -263,6 +263,8 @@ virtual node. >>> Note that virtual NUMA for PV guest is not yet supported, because >>> there is an issue with cpuid handling that affects PV virtual NUMA. >>> +Further more, guest with virtual NUMA cannot be saved or migrated >>> +because node information of guest frames is not preserved. >> Should we also issue a warning during startup if nomigrate is not set? >> > > > Ah, there is such option. I can certainly give a warning. The only > problem is it seems to be stale in libxl, there is no code that checks > that! I can still migrate a guest even with nomigrate set to true. > > Maybe someone with more knowledge about that option can lecture me on > what that does? The manpage says it *enables* certain feature? Does that > actually mean *make available*? IIRC it was added to allow/control certain TSC modes (see domain_cpuid()). -boris