From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Chen, Tiejun" Subject: Re: [PULL 0/19] xen-2015-09-08-tag Date: Thu, 10 Sep 2015 17:20:59 +0800 Message-ID: <55F14B7B.2070706@intel.com> References: <55F0D906.4070606@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Peter Maydell Cc: "xen-devel@lists.xensource.com Devel" , QEMU Developers , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org >> As you see this short log, "hw/pci-assign: split pci-assign.c", so this >> means I just extract something from the original hw/i386/kvm/pci-assign.c, >> and here so I just keep those original head files residing >> hw/i386/kvm/pci-assign.c, and I didn't introduce anything new. > > hw/i386/kvm/pci-assign.c is only built if configure set CONFIG_KVM, > which it won't do on Windows or OSX builds. > > It sounds like your patch has incorrectly moved code out of files > which are compiled only if KVM is present, or only if we're doing > Xen PCI passthrough, and into compiled-for-everything files. > Yes, we want to share this chunk of codes between Xen and Kvm. Just to this error, could we remove #include ? As I mentioned I still can compile this file without this head file. Thanks Tiejun