From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jim Fehlig <jfehlig@suse.com>
Subject: Re: [osstest test] 60719: tolerable FAIL - PUSHED
Date: Fri, 11 Sep 2015 21:56:25 -0600
Message-ID: <55F3A269.8040304@suse.com>
References: <osstest-60719-mainreport@xen.org>	<1440144330.19360.4.camel@citrix.com>
	<55DE8513.3000205@suse.com>	<21989.40565.161215.97306@mariner.uk.xensource.com>	<1441113289.26292.8.camel@citrix.com>
	<55E7EAD9.4090005@suse.com>	<1441276016.26292.334.camel@citrix.com>	<1441280258.26292.349.camel@citrix.com>
	<55E876E8.8000502@suse.com> <1441903229.3549.3.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1441903229.3549.3.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>, xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 09/10/2015 10:40 AM, Ian Campbell wrote:
> On Thu, 2015-09-03 at 10:35 -0600, Jim Fehlig wrote:
>
>> I wonder if this has anything to do with migration V2? I noticed a migration
>> regression a few days back, but later realized that the sender was 4.5 and
>> receiver was 4.6. I planned to see if migration worked through libvirt between
>> two 4.6 hosts, but before doing so I had to re-purpose the machines for another
>> task. I think libvirt needs some work to accommodate migration V2...
> So after shaving a bunch of yakks wrt getting my test boxes setup I've
> finally tracked this one down...

Thanks for investigating this issue! It bubbled to the top of my queue, so I'm 
glad I read this mail before duplicating the effort.

>
> libvirt is passing libxl a restore (and perhaps save) file descriptor which
> is set O_NONBLOCK, which libxl/c doesn't expect and therefore doesn't
> handle the resulting EAGAIN.
>
> Ian and I think it would be more convenient for most callers if libxl took
> care of this by making the fd blocking again and returning it to the
> original state when it was done.
>
> I'll cook up a patch.

I also noticed your patch has been ACK'ed and applied.  Thanks again!

Regards,
Jim