* [PATCH] x86/p2m: fix mismatched unlock
@ 2015-09-14 7:13 Jan Beulich
2015-09-14 8:45 ` Wei Liu
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Jan Beulich @ 2015-09-14 7:13 UTC (permalink / raw)
To: xen-devel; +Cc: George Dunlap, Andrew Cooper, Keir Fraser, Wei Liu
[-- Attachment #1: Type: text/plain, Size: 618 bytes --]
Luckily, due to gfn_unlock() currently mapping to p2m_unlock(), this is
only a cosmetic issue right now.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
Despite its cosmetic nature I think it would be better to also fix this
in 4.6.
--- a/xen/arch/x86/mm/p2m.c
+++ b/xen/arch/x86/mm/p2m.c
@@ -912,7 +912,7 @@ static int set_typed_p2m_entry(struct do
omfn = p2m->get_entry(p2m, gfn, &ot, &a, 0, NULL, NULL);
if ( p2m_is_grant(ot) || p2m_is_foreign(ot) )
{
- p2m_unlock(p2m);
+ gfn_unlock(p2m, gfn, 0);
domain_crash(d);
return -ENOENT;
}
[-- Attachment #2: x86-p2m-set-typed-unlock.patch --]
[-- Type: text/plain, Size: 646 bytes --]
x86/p2m: fix mismatched unlock
Luckily, due to gfn_unlock() currently mapping to p2m_unlock(), this is
only a cosmetic issue right now.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
Despite its cosmetic nature I think it would be better to also fix this
in 4.6.
--- a/xen/arch/x86/mm/p2m.c
+++ b/xen/arch/x86/mm/p2m.c
@@ -912,7 +912,7 @@ static int set_typed_p2m_entry(struct do
omfn = p2m->get_entry(p2m, gfn, &ot, &a, 0, NULL, NULL);
if ( p2m_is_grant(ot) || p2m_is_foreign(ot) )
{
- p2m_unlock(p2m);
+ gfn_unlock(p2m, gfn, 0);
domain_crash(d);
return -ENOENT;
}
[-- Attachment #3: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86/p2m: fix mismatched unlock
2015-09-14 7:13 [PATCH] x86/p2m: fix mismatched unlock Jan Beulich
@ 2015-09-14 8:45 ` Wei Liu
2015-09-14 9:49 ` Andrew Cooper
2015-09-14 10:49 ` George Dunlap
2 siblings, 0 replies; 4+ messages in thread
From: Wei Liu @ 2015-09-14 8:45 UTC (permalink / raw)
To: Jan Beulich; +Cc: George Dunlap, xen-devel, Keir Fraser, Wei Liu, Andrew Cooper
On Mon, Sep 14, 2015 at 01:13:31AM -0600, Jan Beulich wrote:
> Luckily, due to gfn_unlock() currently mapping to p2m_unlock(), this is
> only a cosmetic issue right now.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Wei Liu <wei.liu2@citrix.com>
> ---
> Despite its cosmetic nature I think it would be better to also fix this
> in 4.6.
Release-acked-by: Wei Liu <wei.liu2@citrix.com>
>
> --- a/xen/arch/x86/mm/p2m.c
> +++ b/xen/arch/x86/mm/p2m.c
> @@ -912,7 +912,7 @@ static int set_typed_p2m_entry(struct do
> omfn = p2m->get_entry(p2m, gfn, &ot, &a, 0, NULL, NULL);
> if ( p2m_is_grant(ot) || p2m_is_foreign(ot) )
> {
> - p2m_unlock(p2m);
> + gfn_unlock(p2m, gfn, 0);
> domain_crash(d);
> return -ENOENT;
> }
>
>
>
> x86/p2m: fix mismatched unlock
>
> Luckily, due to gfn_unlock() currently mapping to p2m_unlock(), this is
> only a cosmetic issue right now.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> Despite its cosmetic nature I think it would be better to also fix this
> in 4.6.
>
> --- a/xen/arch/x86/mm/p2m.c
> +++ b/xen/arch/x86/mm/p2m.c
> @@ -912,7 +912,7 @@ static int set_typed_p2m_entry(struct do
> omfn = p2m->get_entry(p2m, gfn, &ot, &a, 0, NULL, NULL);
> if ( p2m_is_grant(ot) || p2m_is_foreign(ot) )
> {
> - p2m_unlock(p2m);
> + gfn_unlock(p2m, gfn, 0);
> domain_crash(d);
> return -ENOENT;
> }
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86/p2m: fix mismatched unlock
2015-09-14 7:13 [PATCH] x86/p2m: fix mismatched unlock Jan Beulich
2015-09-14 8:45 ` Wei Liu
@ 2015-09-14 9:49 ` Andrew Cooper
2015-09-14 10:49 ` George Dunlap
2 siblings, 0 replies; 4+ messages in thread
From: Andrew Cooper @ 2015-09-14 9:49 UTC (permalink / raw)
To: Jan Beulich, xen-devel; +Cc: George Dunlap, Keir Fraser, Wei Liu
On 14/09/15 08:13, Jan Beulich wrote:
> Luckily, due to gfn_unlock() currently mapping to p2m_unlock(), this is
> only a cosmetic issue right now.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86/p2m: fix mismatched unlock
2015-09-14 7:13 [PATCH] x86/p2m: fix mismatched unlock Jan Beulich
2015-09-14 8:45 ` Wei Liu
2015-09-14 9:49 ` Andrew Cooper
@ 2015-09-14 10:49 ` George Dunlap
2 siblings, 0 replies; 4+ messages in thread
From: George Dunlap @ 2015-09-14 10:49 UTC (permalink / raw)
To: Jan Beulich; +Cc: xen-devel, Keir Fraser, Wei Liu, Andrew Cooper
On Mon, Sep 14, 2015 at 8:13 AM, Jan Beulich <JBeulich@suse.com> wrote:
> Luckily, due to gfn_unlock() currently mapping to p2m_unlock(), this is
> only a cosmetic issue right now.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: George Dunlap <george.dunlap@citrix.com>
> ---
> Despite its cosmetic nature I think it would be better to also fix this
> in 4.6.
I agree.
-George
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-09-14 10:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-14 7:13 [PATCH] x86/p2m: fix mismatched unlock Jan Beulich
2015-09-14 8:45 ` Wei Liu
2015-09-14 9:49 ` Andrew Cooper
2015-09-14 10:49 ` George Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).