From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PULL 21/29] xen/pt: Sync up the dev.config and
	data values.
Date: Mon, 14 Sep 2015 12:01:03 +0200
Message-ID: <55F69ADF.40404@redhat.com>
References: <alpine.DEB.2.02.1509101751470.2672@kaball.uk.xensource.com>
	<1441905361-31967-21-git-send-email-stefano.stabellini@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1441905361-31967-21-git-send-email-stefano.stabellini@eu.citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>, peter.maydell@linaro.org
Cc: xen-devel@lists.xensource.com, qemu-devel@nongnu.org
List-Id: xen-devel@lists.xenproject.org



On 10/09/2015 19:15, Stefano Stabellini wrote:
> +
> +        switch (reg->size) {
> +        case 1: rc = xen_host_pci_get_byte(&s->real_device, offset, (uint8_t *)&val);

A bit ugly, and it relies on the host being little endian.

> +                break;
> +        case 2: rc = xen_host_pci_get_word(&s->real_device, offset, (uint16_t *)&val);

Same here.

> +                break;
> +        case 4: rc = xen_host_pci_get_long(&s->real_device, offset, &val);
> +                break;
> +        default: assert(1);

This should be assert(0) or, better, abort().

Paolo